Hi Martin and Andrew,

Thanks for the review and providing a direction towards updating the translations.


Here is an updated webrev with the changes:

http://cr.openjdk.java.net/~kravikumar/8243541/webrev/


All associated tests pass. Please let me know if they look alright.


Thanks,

Kiran

On 27/04/2020 15:16, Martin Buchholz wrote:
Hi Kiran,

Thanks for working on this update so promptly.

The innocent renaming of America/Godthab to America/Nuuk is causing much trouble. Since it's a renaming, both names remain and I expected them to have the same metadata. So I expected the entries in TimeZoneNames.java and the translations in e.g.TimeZoneNames_de.java to have parallel entries for both names.
Which is what happened with Asia/Rangoon rename to Asia/Yangon.
Consider the output of
 $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)'

(I wish IANA would coordinate their tzdata releases with ICU CLDR releases, but apparently they don't)

(I help keep Google's java programs up to date with tzdata)

On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar <kiran.sidhartha.raviku...@oracle.com <mailto:kiran.sidhartha.raviku...@oracle.com>> wrote:

    Hello All,


    Please review the patch for tzdata2020a integration into jdk.

    Release details can be found here:

    http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html
    
<https://urldefense.com/v3/__http://mm.icann.org/pipermail/tz-announce/2020-April/000058.html__;!!GqivPVa7Brio!PGqR3RfBtyodUFrLtWqpA28agMmn_GtHHtKh8oegq3ePykB5KcxVpzelGnZjTxeLKvzw6K2xqoo$>


    Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/

    Bug: https://bugs.openjdk.java.net/browse/JDK-8243541


    The patch has passed all the related testing including JCK and uses
    vanguard format tzdata.


    Thanks,

    Kiran


Reply via email to