Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Thanks. Looks good to me. -Brent On 5/21/19 11:33 AM, naoto.s...@oracle.com wrote: Thanks, Brent. Modified the webrev accordingly: http://cr.openjdk.java.net/~naoto/8224105/webrev.01/ Naoto On 5/21/19 11:03 AM, Brent Christian wrote: Hi, Naoto.  I have a couple comments. src/java.base/shar

Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Thanks, Brent. Modified the webrev accordingly: http://cr.openjdk.java.net/~naoto/8224105/webrev.01/ Naoto On 5/21/19 11:03 AM, Brent Christian wrote: Hi, Naoto.  I have a couple comments. src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java String.isEmpty()

Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Hi, Naoto. I have a couple comments. src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java String.isEmpty() could be used in place of equals(""). test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java Maybe give the new constants names in all-caps.

Re: jtreg test failed with Japanese datetime formatting on win32

This issue should have been fixed by bug JDK-8224142[1]. The fix had been integrated into openjdk8u222. Would you provide the OS version and Java version in your test environment? Kinder reminder, before report the issue and paste the log here, you can search the JBS[2] first. [1] https://bug