Thanks, Brent. Modified the webrev accordingly:
http://cr.openjdk.java.net/~naoto/8224105/webrev.01/
Naoto
On 5/21/19 11:03 AM, Brent Christian wrote:
Hi, Naoto. I have a couple comments.
src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
String.isEmpty() could be used in place of equals("").
test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java
Maybe give the new constants names in all-caps.
-Brent
On 5/20/19 5:20 PM, naoto.s...@oracle.com wrote:
Ping?
Naoto
On 5/17/19 3:43 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8224105
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8224105/webrev.00/
CLDR does not provide entire localized Japanese era names in locales
mentioned in the bug report. The parsing has been failing as they
have duplicate names, despite the duplicates are empty strings.
Naoto
