Re: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10

2019-03-11 Thread Naoto Sato
Looks good to me. I can sponsor your fix. Naoto On 3/11/19 1:57 AM, Toshio 5 Nakamura wrote: Hi Naoto-san, Thank you for reviewing the fix. Could you re-review the updated webrev? http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/ Thanks, Toshio Nakamura naoto.s...@oracle.com wrote on

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-03-11 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion, please ? Thanks, Ichiroh Takiguchi On 2019-02-26 22:08, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/web

Re: Fwd: RFR: JDK-8220414 :Correct copyright headers in Norm2AllModes.java and Normalizer2.java

2019-03-11 Thread Alan Bateman
Looks good. On 11/03/2019 10:06, Rachna Goel wrote: Hi, Kindly review fix to JDK-8220414, which updates copyright header. Bug: https://bugs.openjdk.java.net/browse/JDK-8220414 diff -r 645ba889ee5f src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java --- a/src/java.base/share/c

Fwd: RFR: JDK-8220414 :Correct copyright headers in Norm2AllModes.java and Normalizer2.java

2019-03-11 Thread Rachna Goel
Hi, Kindly review fix to JDK-8220414, which updates copyright header. Bug: https://bugs.openjdk.java.net/browse/JDK-8220414 diff -r 645ba889ee5f src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java --- a/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java Mon Jan

Re: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10

2019-03-11 Thread Toshio 5 Nakamura
Hi Naoto-san, Thank you for reviewing the fix. Could you re-review the updated webrev? http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/ Thanks, Toshio Nakamura naoto.s...@oracle.com wrote on 2019/03/09 02:39:48: > From: naoto.s...@oracle.com > To: Toshio 5 Nakamura , 18n-dev d...@open