Looks good to me. I can sponsor your fix.
Naoto
On 3/11/19 1:57 AM, Toshio 5 Nakamura wrote:
Hi Naoto-san,
Thank you for reviewing the fix.
Could you re-review the updated webrev?
http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/
Thanks,
Toshio Nakamura
naoto.s...@oracle.com wrote on 2019/03/09 02:39:48:
> From: naoto.s...@oracle.com
> To: Toshio 5 Nakamura <toshi...@jp.ibm.com>, 18n-dev <i18n-
> d...@openjdk.java.net>, core-libs-dev <core-libs-...@openjdk.java.net>
> Date: 2019/03/09 02:39
> Subject: Re: <i18n dev> [13] RFR: 8220227: Host Locale Provider
> getDisplayCountry returns error message under non-English Win10
>
> Hi Nakamura-san,
>
> Thanks for fixing this. Since it is using a heuristic way to detect
> "unknown", I'd use String.endsWith() instead of String.contains() both
> in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which
> would be more accurate.
>
> Naoto
>
> On 3/7/19 10:25 PM, Toshio 5 Nakamura wrote:
> >
> > Hi,
> >
> > Could you review this fix? I'd like to have a sponsor of it, since
I'm an
> > author.
> >
> > Bug: INVALID URI REMOVED
>
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8220227&d=DwICaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii--
>
XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=8UA5DKmhd3SIIZmsX8JNOvaQ5wxcIq5bwdtHAnZLsPU&e=
> > Webrev: INVALID URI REMOVED
> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8220227_webrev.
> 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii--
> XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=kLSymGjxW5MrGtWY3zs7VEdg1BN6nYGQjue1w-
> nPs7c&e=
> >
> > Issue:
> > Under Windows 10 non-English, Locale.getDisplayCountry() shows an error
> > message,
> > if Host Locale Provider is used (-Djava.locale.providers=HOST).
> >
> > Fix proposal:
> > The current code compares "Unknown Region (" with the result, but
it could
> > be translated.
> > I believe we can compare it with "("+RegionCode+")", which covers
all 38
> > Language
> > Packs of Windows Server 2016.
> >
> > Thanks,
> > Toshio Nakamura
> >
>
