Re: [9] RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China

2017-03-06 Thread Naoto Sato
Hi Brent, thanks for the review! On 3/6/17 3:21 PM, Brent Christian wrote: Hi, Naoto That fix looks fine. The "Portuguese (Brazil)" fix now happens before the Language ID fix, but that shouldn't matter, as the "pt_BR" ID won't trigger that code anyway (doesn't contain '-'). Yes. One very m

Re: [9] RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China

2017-03-06 Thread Brent Christian
Hi, Naoto That fix looks fine. The "Portuguese (Brazil)" fix now happens before the Language ID fix, but that shouldn't matter, as the "pt_BR" ID won't trigger that code anyway (doesn't contain '-'). One very mall nit I noticed: one more space on line 97 will realign it with line 96, which