Hi Brent, thanks for the review!
On 3/6/17 3:21 PM, Brent Christian wrote:
Hi, Naoto
That fix looks fine.
The "Portuguese (Brazil)" fix now happens before the Language ID fix,
but that shouldn't matter, as the "pt_BR" ID won't trigger that code
anyway (doesn't contain '-').
Yes.
One very mall nit I noticed: one more space on line 97 will realign it
with line 96, which now has an additional '!' character.
Ah, good eye! Will fix it before the push.
That's my small-'r'-review.
:-)
Naoto
-Brent
On 03/03/17 13:19, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8174736
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8174736/webrev.00/
This is a follow-on fix to 8174779 [1]. The previous fix addresses the
issue for the default locale, and this one is to address the default
format locale in order to handle locales with script codes on macOS.
Naoto
[1] https://bugs.openjdk.java.net/browse/JDK-8174779
