Re: [9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Mandy Chung
+1 Mandy > On Jan 23, 2017, at 2:07 PM, Naoto Sato wrote: > > More concise version: > > --- a/src/java.base/share/classes/java/util/ResourceBundle.java > +++ b/src/java.base/share/classes/java/util/ResourceBundle.java > @@ -972,7 +972,9 @@ > * equivalent to calling {@link #getBundle(Strin

Re: [9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Naoto Sato
More concise version: --- a/src/java.base/share/classes/java/util/ResourceBundle.java +++ b/src/java.base/share/classes/java/util/ResourceBundle.java @@ -972,7 +972,9 @@ * equivalent to calling {@link #getBundle(String, Locale, ClassLoader) * getBundle(baseName, targetLocale, module

Re: [9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Naoto Sato
OK, I will clarify the method description of getBundle(String, Locale, Module) as follows: diff -r 290145dc2c96 src/java.base/share/classes/java/util/ResourceBundle.java --- a/src/java.base/share/classes/java/util/ResourceBundle.java +++ b/src/java.base/share/classes/java/util/ResourceBundle.j

Re: [9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Mandy Chung
> On Jan 23, 2017, at 9:14 AM, Naoto Sato wrote: > > http://cr.openjdk.java.net/~naoto/8172365/webrev.05/ > >> >> The fix is to reinstate the code that has been removed with 8171189, >> with modification to load implementations with ServiceLoader.load() >> method. That way, SPI implementations

Re: [9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Naoto Sato
Correct link to the changes: http://cr.openjdk.java.net/~naoto/8172365/webrev.05/ Naoto On 1/23/17 9:13 AM, Naoto Sato wrote: Hi, Please review the changes for the following issue: https://bugs.openjdk.java.net/browse/JDK-8172365 The proposed fix is located at: http://cr.openjdk.java.net/~

[9] RFR: 8172365: Provide a better migration path for ResourceBundleControlProvider

2017-01-23 Thread Naoto Sato
Hi, Please review the changes for the following issue: https://bugs.openjdk.java.net/browse/JDK-8172365 The proposed fix is located at: http://cr.openjdk.java.net/~rgoel/JDK-8167273/webrev.05/ The fix is to reinstate the code that has been removed with 8171189, with modification to load impl

Re: RFR: 8167273: Calendar.getDisplayNames inconsistent with DateFormatSymbols

2017-01-23 Thread Naoto Sato
Looks good to me. Naoto On 1/22/17 11:22 PM, Rachna Goel wrote: Hi, kindly review fix for JDK-8167273. Bug : https://bugs.openjdk.java.net/browse/JDK-8167273 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8167273/webrev.05/ Fix : Considering GregorianCalendar only, when CLDR is default provid