> On Jan 23, 2017, at 9:14 AM, Naoto Sato <naoto.s...@oracle.com> wrote: > > http://cr.openjdk.java.net/~naoto/8172365/webrev.05/ > >> >> The fix is to reinstate the code that has been removed with 8171189, >> with modification to load implementations with ServiceLoader.load() >> method. That way, SPI implementations can be searched on application's >> class path.
This change is reasonable. The custom control provider can only be used for loading of resource bundles in unnamed modules which maintains JDK 8 behavior. For the getBundle factory methods taking Module parameter, I suggest to explain the spec to clarify that the custom control provider will be used to load the resource bundle if the specified module is unnamed module. Otherwise looks good. Mandy
