Re: Review Request-JDK-8154797:Localization data for "GMT"

2016-07-13 Thread Masayoshi Okutsu
+1 Masayoshi On 7/14/2016 2:15 AM, Naoto Sato wrote: +1 Naoto On 7/13/16 10:14 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. Please have a look at updated webrev : http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.05/ Thanks, Rachna On 7/13/2016 9:04 PM, Naoto Sato wrote: H

Re: Review Request-JDK-8154797:Localization data for "GMT"

2016-07-13 Thread Rachna Goel
Hi Naoto, Thanks for the review. Please have a look at updated webrev : http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.05/ Thanks, Rachna On 7/13/2016 9:04 PM, Naoto Sato wrote: Hi Rachna, Did you intend to use Locale.GERMANY/JAPAN/US, instead of Locale.GERMAN/JAPANESE/ENGLISH in Bug81

Re: Review Request-JDK-8154797:Localization data for "GMT"

2016-07-13 Thread Naoto Sato
+1 Naoto On 7/13/16 10:14 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. Please have a look at updated webrev : http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.05/ Thanks, Rachna On 7/13/2016 9:04 PM, Naoto Sato wrote: Hi Rachna, Did you intend to use Locale.GERMANY/JAPAN/US,

Re: Review Request-JDK-8154797:Localization data for "GMT"

2016-07-13 Thread Naoto Sato
Hi Rachna, Did you intend to use Locale.GERMANY/JAPAN/US, instead of Locale.GERMAN/JAPANESE/ENGLISH in Bug8154797.java? You can also use Locale.FRANCE and Locale.UK constants in the test case. Otherwise it looks good. Naoto On 7/13/16 2:01 AM, Rachna Goel wrote: Hi, Please review fix for

Review Request-JDK-8154797:Localization data for "GMT"

2016-07-13 Thread Rachna Goel
Hi, Please review fix for JDK-8154797. Bug: https://bugs.openjdk.java.net/browse/JDK-8154797 webrev: http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.04/ fix summary: Added support for GMT Localization resources (GmtFormat and hourFormat). For more info: http://unicode.org/repos/cldr/tru