Re: Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

2016-06-27 Thread Masayoshi Okutsu
+1 Masayoshi On 6/28/2016 2:12 AM, Naoto Sato wrote: I'd wrap long lines, others look good to me. Naoto On 6/27/16 2:46 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. I have modified test as per suggestions. Please have a look at : http://cr.openjdk.java.net/~rgoel/8158504/webrev

Re: Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

2016-06-27 Thread Naoto Sato
I'd wrap long lines, others look good to me. Naoto On 6/27/16 2:46 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. I have modified test as per suggestions. Please have a look at : http://cr.openjdk.java.net/~rgoel/8158504/webrev.06/ Regards, Rachna On 6/23/2016 9:35 PM, Naoto Sato w

Re: Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

2016-06-27 Thread Rachna Goel
Hi Naoto, Thanks for the review. I have modified test as per suggestions. Please have a look at : http://cr.openjdk.java.net/~rgoel/8158504/webrev.06/ Regards, Rachna On 6/23/2016 9:35 PM, Naoto Sato wrote: Hi Rachna, The test needs to be modified to ensure locales only for ROOT and en_US*