Re: Review Request for JDK-8149452: j.t.SimpleDateFormat.getDateFormatSymbols().getZoneStrings() returns incorrect result for some time zones

2016-05-19 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 5/18/2016 6:38 PM, Nishit Jain wrote: Hello All, Please review the fix for JDK-8149452 Bug: https://bugs.openjdk.java.net/browse/JDK-8149452 Webrev: http://cr.openjdk.java.net/~nishjain/8149452/webrev.01/ Fix: Made some changes to the CLDRConverter.java to han

Re: Review Request for JDK-7102969 and JDK-8157138: "currency.properties supercede..." and "Error while fetching currency instance..."

2016-05-19 Thread Masayoshi Okutsu
+1 Masayoshi On 5/19/2016 5:40 PM, Yuka Kamiya wrote: Hi Nishit, The fix looks okay to me. Thanks, -- Yuka On 2016/05/19 16:04, Nishit Jain wrote: Hello All, Please review the updated webrev synced with the latest repository. http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webre

Re: Review Request for JDK-7102969 and JDK-8157138: "currency.properties supercede..." and "Error while fetching currency instance..."

2016-05-19 Thread Yuka Kamiya
Hi Nishit, The fix looks okay to me. Thanks, -- Yuka On 2016/05/19 16:04, Nishit Jain wrote: Hello All, Please review the updated webrev synced with the latest repository. http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webrev.08/ Regards, Nishit Jain On 5/18/2016 3:42 PM, Nishit J

Re: Review Request for JDK-7102969 and JDK-8157138: "currency.properties supercede..." and "Error while fetching currency instance..."

2016-05-19 Thread Nishit Jain
Hello All, Please review the updated webrev synced with the latest repository. http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webrev.08/ Regards, Nishit Jain On 5/18/2016 3:42 PM, Nishit Jain wrote: Hello All, Please review the fix for JDK-7102969 and JDK-8157138 (Fixing multiple b