Looks good to me.
Masayoshi
On 3/29/2013 11:25 AM, Seán Coffey wrote:
Masayoshi,
this is a JDK 8 review request for an issue we touched on a good while
back. As suggested by you, fix is to clear ZONE_OFFSET field of the
calendar being built before attempting to set a DST_OFFSET value. I
pla
Masayoshi,
this is a JDK 8 review request for an issue we touched on a good while
back. As suggested by you, fix is to clear ZONE_OFFSET field of the
calendar being built before attempting to set a DST_OFFSET value. I plan
to backport to 7u-dev after a few weeks of soak time.
bug report : ht
Ah, did not see your email before I sent out the revised webrev. Please
find my comments below:
On 3/28/13 8:03 AM, Masayoshi Okutsu wrote:
Additional comments (to the CFStringRef to jchar[] conversion).
- There might be exceptional cases on zero digit handling in CLDR. One
is that digits aren
Updated the changeset according to an internal review (using
CFStringGetCharacterAtIndex() instead of converting entire string on
MacOSX). Here is the revised webrev:
http://cr.openjdk.java.net/~naoto/7091601/webrev.01/
Naoto
On 3/22/13 1:23 PM, Naoto Sato wrote:
Hello,
Please review the ch
Additional comments (to the CFStringRef to jchar[] conversion).
- There might be exceptional cases on zero digit handling in CLDR. One
is that digits aren't sequential in "hanidec" which can't be supported
with the current java.text classes. Another one is that digits are in a
reversed order i