Additional comments (to the CFStringRef to jchar[] conversion).

- There might be exceptional cases on zero digit handling in CLDR. One is that digits aren't sequential in "hanidec" which can't be supported with the current java.text classes. Another one is that digits are in a reversed order in "nkoo". I don't know if these are applicable to Mac OS, but it should be worth checking.

- I noticed that the native getCalendarID returns a jstring, but that the Java code appears to except an int.

- createCFLocale() seems to convert a jstring to char* and to CFStringRef. I wonder if this can be simplified.

Thanks,
Masayoshi

On 3/23/2013 5:23 AM, Naoto Sato wrote:
Hello,

Please review the changes for the following bug:

http://bugs.sun.com/view_bug.do?bug_id=7091601

The idea is to reflect the operating system's settings in the HOST locale provider adapter. Also fixed a bug in MacOSX code conversion for the zero digit. The webrev is available here:

http://cr.openjdk.java.net/~naoto/7091601/webrev.00/

Naoto

Reply via email to