Re: [html-formfu] filename case

2007-08-17 Thread Carl Franks
As an experiment, I've implemented the change to CamelCase element filenames - and have checked it in - including necessary changes in DBIx-Class-HTML-FormFu, HTML-FormFu-Dojo and HTML-FormFu-Imager. I'll try to get the time over the weekend to update a couple of cat apps to the very latest svn ve

Re: [html-formfu] filename case

2007-08-17 Thread Carl Franks
On 17/08/07, Brian Cassidy <[EMAIL PROTECTED]> wrote: > Carl Franks wrote: > > Sigh, I just didn't want to mess people about by renaming all the > > Element files to CamelCase - when I did the exact opposite 5 months > > ago. > > That's really the only reason I suggested such a complicated solution

Re: [html-formfu] filename case

2007-08-17 Thread Moritz Onken
I'd prefer CamelCase too. The config should allow CamelCase as well as spaces between words. And maybe without spaces also. That could be done by lc'ing the class name and the config name and then comparing. Just a thought... Carl Franks schrieb: On 17/08/07, Brian Cassidy <[EMAIL PROTECTED]> w

Re: [html-formfu] filename case

2007-08-17 Thread Brian Cassidy
Carl Franks wrote: Sigh, I just didn't want to mess people about by renaming all the Element files to CamelCase - when I did the exact opposite 5 months ago. That's really the only reason I suggested such a complicated solution. And I feel the current inconsistency has the potential to cause conf

Re: [html-formfu] filename case

2007-08-17 Thread Carl Franks
On 17/08/07, Brian Cassidy <[EMAIL PROTECTED]> wrote: > Carl Franks wrote: > > I'm not entirely happy with all element filenames being lowercase, and > > everything else being CamelCaps. > > What I think would be better, would be to have all files under: > >Elements/ > >Deflators/ > >Fi

Re: [html-formfu] filename case

2007-08-17 Thread Brian Cassidy
Carl Franks wrote: I'm not entirely happy with all element filenames being lowercase, and everything else being CamelCaps. What I think would be better, would be to have all files under: Elements/ Deflators/ Filters/ Constraints/ Inflators/ Validators/ Transformers/ to be low

Re: [html-formfu] RFC: i18n key changes

2007-08-17 Thread Carl Franks
On 16/08/07, Brian Cassidy <[EMAIL PROTECTED]> wrote: > Carl Franks wrote: > > I propose changing the key to the format: "form_${processor}_${type}" > > +1 > > That seems like a sane default. Committed! Carl ___ HTML-FormFu mailing list HTML-FormFu@lis

Re: [html-formfu] Multiple Submits

2007-08-17 Thread Carl Franks
On 15/08/07, Moritz Onken <[EMAIL PROTECTED]> wrote: > There is a little bug. If you do it as I wrote the value of the > unclicked button will be "" after submission. If you have an error on > that form the new page will have an empty submit button. > > > $form->add_valid( $_->name, $_->val

[html-formfu] filename case

2007-08-17 Thread Carl Franks
Ok, there's just 1 more issue that I can think of that needs addressed before a CPAN release. I'm not entirely happy with all element filenames being lowercase, and everything else being CamelCaps. What I think would be better, would be to have all files under: Elements/ Deflators/ Filter