Re: [hibernate-dev] Jira - edit comments

2018-10-18 Thread Sanne Grinovero
I can't remember ever being allowed to edit comments. For sure it wasn't allowed years back, I don't honestly know about recent times as I never tried - probably having been coached by the old rule :) On Thu, 18 Oct 2018, 11:06 Steve Ebersole, wrote: > Did someone remove the ability to edit on

Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Sanne Grinovero
Since this is a rather un-interesting topic I guess I'll just proceed with a PR: - https://github.com/hibernate/hibernate-orm/pull/2594 It can easily be reverted in case someone badly wants it back. On Wed, 17 Oct 2018 at 16:26, Sanne Grinovero wrote: > > Currently this method is used but not do

Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Steve Ebersole
For me its ok. We end up handling each of these specifically anyway nowadays. On Thu, Oct 18, 2018 at 6:16 AM Sanne Grinovero wrote: > Since this is a rather un-interesting topic I guess I'll just proceed with > a PR: > - https://github.com/hibernate/hibernate-orm/pull/2594 > > It can easily be

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 07:39, Yoann Rodiere wrote: > > Can't say if it's a good or bad idea, but if you don't document it in the > user guide, please at least document how dangerous it is and why it can be > useful in the source code where the "none" option appears. I expect some > users will f

Re: [hibernate-dev] Jira - edit comments

2018-10-18 Thread Steve Ebersole
For sure it *was* allowed for years ;) Initially I set up the permissions that a user could edit their own comments. I think admins could edit any, but I do not remember that part for sure. On Thu, Oct 18, 2018 at 5:17 AM Sanne Grinovero wrote: > > I can't remember ever being allowed to edit c

Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 12:29, Steve Ebersole wrote: > > For me its ok. We end up handling each of these specifically anyway nowadays. Thanks! I'll merge then. > > On Thu, Oct 18, 2018 at 6:16 AM Sanne Grinovero wrote: >> >> Since this is a rather un-interesting topic I guess I'll just proceed

Re: [hibernate-dev] Jira - edit comments

2018-10-18 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 12:39, Steve Ebersole wrote: > > For sure it *was* allowed for years ;) Ok, maybe it was just in my mind, but because of that I never tried so I would never have noticed any change :) For sure I didn't reconfigure that myself. > > Initially I set up the permissions that a

Re: [hibernate-dev] Jira - edit comments

2018-10-18 Thread Steve Ebersole
Interesting... That is still the permission in the settings. But for some reason I cannot. I do not think the issue was closed, but honestly its now been a few days and I forget which issue it is :( On Thu, Oct 18, 2018 at 6:45 AM Sanne Grinovero wrote: > On Thu, 18 Oct 2018 at 12:39, Steve Eb

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Guillaume Smet
Hi, On Thu, Oct 18, 2018 at 1:33 PM Sanne Grinovero wrote: > > Regarding "BasicProxyFactory", Guillaume and I had to fight with this > think a few weeks ago, I think. If I remember correctly, it's used in > particular to instantiate abstract classes (!) during bootstrap. It seems > to be needed

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Steve Ebersole
We need to keep it working without enhancement, bugs or not On Thu, Oct 18, 2018, 8:27 AM Guillaume Smet wrote: > Hi, > > On Thu, Oct 18, 2018 at 1:33 PM Sanne Grinovero > wrote: > > > > Regarding "BasicProxyFactory", Guillaume and I had to fight with this > > think a few weeks ago, I think. I

[hibernate-dev] HBX-1193 (oracle) reverse engineering of UniqueConstraint annotation for function-based indexes

2018-10-18 Thread Graham Collinson
___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev