On Thu, 18 Oct 2018 at 12:29, Steve Ebersole <st...@hibernate.org> wrote: > > For me its ok. We end up handling each of these specifically anyway nowadays.
Thanks! I'll merge then. > > On Thu, Oct 18, 2018 at 6:16 AM Sanne Grinovero <sa...@hibernate.org> wrote: >> >> Since this is a rather un-interesting topic I guess I'll just proceed with a >> PR: >> - https://github.com/hibernate/hibernate-orm/pull/2594 >> >> It can easily be reverted in case someone badly wants it back. >> >> On Wed, 17 Oct 2018 at 16:26, Sanne Grinovero <sa...@hibernate.org> wrote: >> > >> > Currently this method is used but not doing much at all, as maps >> > OBSOLETE_PROPERTIES and RENAMED_PROPERTIES are constant and empty. >> > >> > I'm wondering if this is because it's just a coincidence at this point >> > in time we have nothing registered in those maps, or if this strategy >> > is just no longer the preferred choice to handle "out of date >> > configuration properties". >> > >> > I'm guessing that going forward we all rather implement such logic >> > using ad-hoc logic and more specific error messages? >> > >> > In that case I'd want to deprecate this code and remove those maps. >> > Objections? >> > >> > Thanks, >> > Sanne >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
