Re: [hibernate-dev] org.hibernate.event.spi Listener changes for 6 ?

2017-05-17 Thread Sanne Grinovero
On 17 May 2017 at 02:23, Steve Ebersole wrote: > Jira please or we will forget. Assign it to Alpha2 for now - https://hibernate.atlassian.net/browse/HHH-11755 - https://hibernate.atlassian.net/browse/HHH-11756 Is it a good time to help out with 6.0 ? I've been staying clear from it as you all

[hibernate-dev] [ORM] Event Listeners: what's the consequence of not implementing Serializable correctly?

2017-05-17 Thread Sanne Grinovero
As you might know Hibernate Search is implemented mainly as a complex Event Listener to events from Hibernate ORM. The Hibernate ORM event listener contracts "suggest" that such event listeners need to be Serializable, but it seems our listeners is not actually serializable since some time. It app

Re: [hibernate-dev] org.hibernate.event.spi Listener changes for 6 ?

2017-05-17 Thread Steve Ebersole
Thanks, I'll check them out. As to your questions... 1. Now would be fine to tackle these if you wish. What we are working on should not really impact places you are talking about. I said Alpha 2 earlier because I meant it was not going to be a priority for us any time soon, althoug

Re: [hibernate-dev] org.hibernate.event.spi Listener changes for 6 ?

2017-05-17 Thread Sanne Grinovero
On 17 May 2017 at 14:56, Steve Ebersole wrote: > Thanks, I'll check them out. > > As to your questions... > > Now would be fine to tackle these if you wish. What we are working on > should not really impact places you are talking about. I said Alpha 2 > earlier because I meant it was not going t

Re: [hibernate-dev] org.hibernate.event.spi Listener changes for 6 ?

2017-05-17 Thread Steve Ebersole
As you prefer. Like I said it is is ~ item #99 on the list for me, Andrea and Chris. So depends how important it is to you On Wed, May 17, 2017 at 9:00 AM Sanne Grinovero wrote: > On 17 May 2017 at 14:56, Steve Ebersole wrote: > > Thanks, I'll check them out. > > > > As to your questions.

Re: [hibernate-dev] [ORM] Event Listeners: what's the consequence of not implementing Serializable correctly?

2017-05-17 Thread Steve Ebersole
We actually never serialize the SessionFactory and therefore never the EventListenerGroup. Our serialized form of a SessionFactory is actually just its UUID and its (JNDI) name. It is completely unnecessary for them to be Serializable. Not to mention it make no sense for an interface to force an

Re: [hibernate-dev] [ORM] Event Listeners: what's the consequence of not implementing Serializable correctly?

2017-05-17 Thread Sanne Grinovero
On 17 May 2017 at 20:25, Steve Ebersole wrote: > We actually never serialize the SessionFactory and therefore never the > EventListenerGroup. Our serialized form of a SessionFactory is actually > just its UUID and its (JNDI) name. > > It is completely unnecessary for them to be Serializable. Not