On 17 May 2017 at 02:23, Steve Ebersole <st...@hibernate.org> wrote: > Jira please or we will forget. Assign it to Alpha2 for now
- https://hibernate.atlassian.net/browse/HHH-11755 - https://hibernate.atlassian.net/browse/HHH-11756 Is it a good time to help out with 6.0 ? I've been staying clear from it as you all seem to be making very quick cycles and aggressive refactorings - hard to dive in when I can only spare a few hours - but if it's a good time I'm happy to push these myself. Please assign them and set the "fix versions" as you wish. Thanks, Sanne > > On Tue, May 16, 2017 at 7:01 PM Steve Ebersole <st...@hibernate.org> wrote: >> >> On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero <sa...@hibernate.org> >> wrote: >>> >>> Since 6 is coming I'd like to suggest two trivial changes for the >>> listeners: >>> >>> # Serializable >>> >>> I assume we can drop the "extend Serializable" from all these interfaces >>> ? >>> >> >> Personally I've never been a fan of interfaces extending Serializable, so >> I am fine with that. >> >> >>> >>> # PostInsertEventListener.requiresPostCommitHanding(EntityPersister) >>> >>> I suspect there is a typo in this method? >>> N.B. there are some more copies of `requiresPostCommitHanding` in >>> other listeners, beyond the PostInsertEventListener. >> >> >> Fine by me, but I wonder if we ought to deprecate it instead and use >> default methods. Or maybe do that retro in 5.2 and do clean in 6 _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
