After reading this thread, `family` or `private` feel better than `friend`
BTW, can’t you isolate those classes in a dedicated package still marked `impl`
but have it exposed to OSGi?
After all all this "shared but not shared because we decided to cut our
software in many pieces“ is a bit of an
Hi,
> One of today's issues for Hibernate Search had the goal to move this class:
>
> org.hibernate.search.engine.spi.SearchFactoryImplementor
Well, for me there is more to this than just moving. There are two issues imo.
1. The location. org.hibernate.search.engine.spi implies after our defini
Hi,
On Mon, Dec 08, 2014 at 10:47:25AM +0100, Emmanuel Bernard wrote:
> BTW, can’t you isolate those classes in a dedicated package still marked
> `impl` but have it exposed to OSGi?
That was my suggestion as well. It is probably not the worst alternative. It
moves the class out of the spi
pack
Ok that sounds like the best compromise. I'll adjust my open PR.
Thanks!
Sanne
On 8 December 2014 at 10:18, Hardy Ferentschik wrote:
> Hi,
>
> On Mon, Dec 08, 2014 at 10:47:25AM +0100, Emmanuel Bernard wrote:
>> BTW, can’t you isolate those classes in a dedicated package still marked
>> `impl`
On 8 December 2014 at 10:13, Hardy Ferentschik wrote:
> Hi,
>
>> One of today's issues for Hibernate Search had the goal to move this class:
>>
>> org.hibernate.search.engine.spi.SearchFactoryImplementor
>
> Well, for me there is more to this than just moving. There are two issues imo.
>
> 1. The
On Mon, Dec 08, 2014 at 12:07:45PM +, Sanne Grinovero wrote:
> > 2. The name. SearchFactoryImplementor is something which implements
> > SearchFactory. However,
> >one of the latest changes was to make SearchFactory a stand alone class
> > of the orm module.
> >SearchFactory is now on
> On 08 Dec 2014, at 14:34, Hardy Ferentschik wrote:
>
> On Mon, Dec 08, 2014 at 12:07:45PM +, Sanne Grinovero wrote:
>>> 2. The name. SearchFactoryImplementor is something which implements
>>> SearchFactory. However,
>>> one of the latest changes was to make SearchFactory a stand alone c
