Ok that sounds like the best compromise. I'll adjust my open PR. Thanks! Sanne
On 8 December 2014 at 10:18, Hardy Ferentschik <ha...@hibernate.org> wrote: > Hi, > > On Mon, Dec 08, 2014 at 10:47:25AM +0100, Emmanuel Bernard wrote: >> BTW, can’t you isolate those classes in a dedicated package still marked >> `impl` but have it exposed to OSGi? > > That was my suggestion as well. It is probably not the worst alternative. It > moves the class out of the spi > package and makes it an impl class (properly indicating that it is not to be > used by anyone else). > The downside is that we still need to expose this impl package via OSGi. > However, since it would be a "dedicated" > package just for this integration code, the impact would be minimal. > > Mind you, I still believe that we could address the whole issue in a much > cleaner way as well. > > --Hardy _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
