Re: [hibernate-dev] Hibernate Commons project

2017-02-08 Thread Emmanuel Bernard
> On 7 Feb 2017, at 12:03, Guillaume Smet wrote: > > Hi, > > On Mon, Feb 6, 2017 at 4:21 PM, Emmanuel Bernard > wrote: > On the license, I think ASL 2.0 is the best for such project. > > As we discussed it in Lisbon, we might "copy" (using Maven) sources from an

Re: [hibernate-dev] Hibernate Commons project

2017-02-07 Thread Guillaume Smet
Hi, So, apparently, people didn't like internal in the groupId so we ended up with org.hibernate.infra which was one of the groupIds suggested by Emmanuel. The Asciidoctor theme is here: https://github.com/hibernate/hibernate-asciidoctor-theme . I just pushed the first version to our Nexus so I

Re: [hibernate-dev] Hibernate Commons project

2017-02-07 Thread Guillaume Smet
Hi, On Mon, Feb 6, 2017 at 4:21 PM, Emmanuel Bernard wrote: > On the license, I think ASL 2.0 is the best for such project. > As we discussed it in Lisbon, we might "copy" (using Maven) sources from an internal utility project to the NoORM projects, as we want to avoid dependency hell with diff

Re: [hibernate-dev] Hibernate Commons project

2017-02-06 Thread Sanne Grinovero
On 6 February 2017 at 15:21, Emmanuel Bernard wrote: > Hey all, > > On the license, I think ASL 2.0 is the best for such project. > On the group id, am I right that this project is some utilities used by us > internally? And would not be imported by a user? That's what I hope should be the inten

Re: [hibernate-dev] Hibernate Commons project

2017-02-06 Thread Emmanuel Bernard
Hey all, On the license, I think ASL 2.0 is the best for such project. On the group id, am I right that this project is some utilities used by us internally? And would not be imported by a user? If true then I’d avoid common as it feels like something that a user would import. internal could wo

Re: [hibernate-dev] Hibernate Commons project

2017-01-31 Thread Guillaume Smet
On Tue, Jan 31, 2017 at 11:34 AM, Gunnar Morling wrote: > == Repo organization == > > I would prefer to have the AsciiDoc style, shared testing utilities > and other utilities in separate repos, not a shared one. To me, a repo > represents a coherent unit of "things" with its own lifecycle. Updat

Re: [hibernate-dev] Hibernate Commons project

2017-01-31 Thread Gunnar Morling
Hi, Some thoughts: == Group Id == Should be something like "org.hibernate.common" as per our discussions from last week. == Repo organization == I would prefer to have the AsciiDoc style, shared testing utilities and other utilities in separate repos, not a shared one. To me, a repo represents

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Guillaume Smet
On Mon, Jan 30, 2017 at 5:36 PM, Steve Ebersole wrote: > Disclaimer : I have not yet looked at the Asciidoc style. Again I promise > to look at it when I come back from PTO. That said I want to make certain > that the developed style matches the new ORM documentation style. The > design team

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Steve Ebersole
Disclaimer : I have not yet looked at the Asciidoc style. Again I promise to look at it when I come back from PTO. That said I want to make certain that the developed style matches the new ORM documentation style. The design team at Red Hat spent a lot of time helping us develop that. Specifica

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Guillaume Smet
On Mon, Jan 30, 2017 at 3:26 PM, Yoann Rodiere wrote: > > On 30 January 2017 at 13:58, Guillaume Smet > wrote: > >> Note that the current version of hibernate-commons-annotations is >> org.hibernate.common (without the s at the end, not org.hibernate as Yoann >> stated it). >> > You're right. Wo

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Yoann Rodiere
On 30 January 2017 at 13:58, Guillaume Smet wrote: > Note that the current version of hibernate-commons-annotations is > org.hibernate.common (without the s at the end, not org.hibernate as Yoann > stated it). > You're right. Wouldn't the simplest solution be to use the same groupId (without a "

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Guillaume Smet
On Mon, Jan 30, 2017 at 12:44 PM, Sanne Grinovero wrote: > # groupId > +1 for the name "hibernate-commons". > > I wouldn't want to move the hibernate-commons-annotations project > though. This project is stable, not evolving much yet several branches > will need to be maintained for very long tim

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Sanne Grinovero
# groupId +1 for the name "hibernate-commons". I wouldn't want to move the hibernate-commons-annotations project though. This project is stable, not evolving much yet several branches will need to be maintained for very long time still. Moving repositories would make maintenance trickier for no ot

Re: [hibernate-dev] Hibernate Commons project

2017-01-30 Thread Yoann Rodiere
Everything you said seems to make sense to me, so +1. We can see later whether we agree on the other common projects we could add (checkstyle rules, test utils, ...), but I think there won't be many arguments *against* them as long as there is no transitive dependency to these projects for end user