Thanks,
I will apply the changes this evening.
1) Move content of org.hibernate.search.util.logging to
org.hibernate.search.util.logging.impl
2) Use less friendly %1$s when there is more than one parameter
3) I need to check how to do the exception internationalization.
Cheers,
Davide
On Fri, Ju
Agreed,
Davide can you update that single commit which does the package rename
to the new name? Then let me know so I'll pull it in and you can
resolve the issue.
Thanks!
Sanne
2011/6/10 Emmanuel Bernard :
> Hello Sanne and Davide.
>
> First of all awesome job :)
> I've added a few comments in th
Hello Sanne and Davide.
First of all awesome job :)
I've added a few comments in the pull request, here are a couple more.
The package should be something.something.impl as it's not meant to be
published to users.
org.hibernate.search.util.logging.impl is fine by me.
We might want to adjust so
