Thanks, I will apply the changes this evening. 1) Move content of org.hibernate.search.util.logging to org.hibernate.search.util.logging.impl 2) Use less friendly %1$s when there is more than one parameter 3) I need to check how to do the exception internationalization.
Cheers, Davide On Fri, Jun 10, 2011 at 9:26 AM, Sanne Grinovero <sa...@hibernate.org> wrote: > Agreed, > Davide can you update that single commit which does the package rename > to the new name? Then let me know so I'll pull it in and you can > resolve the issue. > > Thanks! > Sanne > > 2011/6/10 Emmanuel Bernard <emman...@hibernate.org>: >> Hello Sanne and Davide. >> >> First of all awesome job :) >> I've added a few comments in the pull request, here are a couple more. >> >> The package should be something.something.impl as it's not meant to be >> published to users. >> >> org.hibernate.search.util.logging.impl is fine by me. >> >> We might want to adjust some log levels according to >> http://community.jboss.org/wiki/HowToLogInJBossProjects >> I have not checked whether or not we are conformant but we will need to >> investigate at some point (a different pull request of course). >> >> Emmanuel >> >> >> On 10 juin 2011, at 02:03, Sanne Grinovero wrote: >> >>> Hello, >>> this pull request by Davide is looking ok for me, as we've been >>> iterating on it a while now, but I would like a brief review from >>> someone else, at least your opinion about: >>> >>> 1- the final package name of the logger: package >>> org.hibernate.search.util.logging >>> >>> 2- he did on purpose not convert the archetype, still using slf4j in >>> the example for the "user app": keeps things simpler as enabling the >>> processor in eclipse still requires some non trivial manual steps >>> [JBIDE-8208] to be documented on the wiki >>> >>> https://github.com/hibernate/hibernate-search/pull/95 >>> >>> Sanne >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
