Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-21 Thread Steve Ebersole
Its actually in 3.3 already as well - Steve Ebersole Project Lead http://hibernate.org [EMAIL PROTECTED] Principal Software Engineer JBoss, a division of Red Hat http://jboss.com http://redhat.com [EMAIL PROTECTED] [EMAIL PROTECTED] On Fri, 2008-11-21 at 09:26 +0100, Max Rydahl Andersen wrot

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-21 Thread Max Rydahl Andersen
Next major release of Hibernate will be much more modularized than earlier. It's in trunk, so not something that is going to show up in 3.2.x. -max hibernate-jmx is actually news to me - I didn't realize there was such a module. Is it easy for someone with an existing app to plop this hiber

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-21 Thread John Mazzitelli
hibernate-jmx is actually news to me - I didn't realize there was such a module. Is it easy for someone with an existing app to plop this hibernate-jmx module (.jar?) in their app deployment and have it "just work"? I'm curious if this is going to be shipped with, say, JBossAS, so its alread

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-21 Thread John Mazzitelli
That's saying "use the platform MBeanServer" *and* "use the MBeanServer with a default domain name of "my_mbean_server". Which takes effect? I didn't want someone to do something confusing like this. I understand. But we can raise a config exception and fail fast. With your approach, if I nam

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-21 Thread Max Rydahl Andersen
John, follow Steve's lead and put it in hibernate-jmx module. These statistics have been hidden all too long for users of Hibernate IMO. This setting will make it available. IMO it is not a security issue since its not enabled by default and similar to users of AS can go enable jmx console witho

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread John Mazzitelli
But even under JSE it's trivial to publish an MBean in a few lines of Java code as well: Well, that's my whole point in this exercise. We shouldn't require people to introduce this code (albeit trivial) in their app just so it can be monitored (after all, how many app developers actually take

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread Elias Ross
On Thu, Nov 20, 2008 at 5:00 PM, John Mazzitelli <[EMAIL PROTECTED]> wrote: > You assume the hibernate app is always running in a container that supports > that. > > But, by definition, Hibernate is not required to be running in any kind of > container environment - it is designed to be able to run

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread John Mazzitelli
You assume the hibernate app is always running in a container that supports that. But, by definition, Hibernate is not required to be running in any kind of container environment - it is designed to be able to run even in a simple J2SE environment. As such, it should not solely rely on its e

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread Elias Ross
Spring and a lot of other containers like JBoss's Microcontainer make it pretty easy to deploy the statistics MBean. E.g. in Spring:

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread John Mazzitelli
I don't know the MBean security model. How do I ensure that an given MBean is restricted in view / write access? This is a good point. But I would say that security could be imposed on the level of JMX remoting. For example, I could enable SSL on the JMX connector using SUN's com.sun.managment

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread Emmanuel Bernard
On Nov 20, 2008, at 11:47, John Mazzitelli wrote: To be sure, hibernate.generate_statistics is usually not enough if you want to use a monitoring tool (since it is generally not the case that your monitoring tool is running in the same VM as the hibernate app and can access the statistics

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread Steve Ebersole
Since this code deals with JMX, I'd rather see this functionality as part of the hibernate-jmx module which I am totally fine making JDK 1.5 specific. The implication of that though is that you'd need to move all code outside of the hibernate-core module and bootstrap it another way (perhaps as a

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread John Mazzitelli
To be sure, hibernate.generate_statistics is usually not enough if you want to use a monitoring tool (since it is generally not the case that your monitoring tool is running in the same VM as the hibernate app and can access the statistics object directly). The main problem is that it feels od

Re: [hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-20 Thread Emmanuel Bernard
I remember doing something like that when I worked initially on Statistics but Gavin did not like it and I did not like it enough to argue. I never committed it. The main problem is that it feels odd for Hibernate to be responsible for the Bean Server startup. If we nevertheless go that p

[hibernate-dev] exposing statistics easier (HHH-3593 solution)

2008-11-19 Thread John Mazzitelli
I recently added support to Jopr, The JBoss management platform project ( http://www.jboss.org/jopr ) to be able to monitor Hibernate via the Hibernate Statistics MBean. For background, see my blog entry: http://management-platform.blogspot.com/2008/11/monitoring-hibernate.html and more spec