Re: [hibernate-dev] Relaxing the pull request review requirement

2013-05-02 Thread Scott Marlow
The downside of waiting for a pull request to be merged by someone else is that it can take away some of the fun of contributing. Sometimes, I think sequentially and having to wait for a pull request to be merged can hurt my flow. I'm speaking from my experience with non-Hibernate Search proje

Re: [hibernate-dev] Relaxing the pull request review requirement

2013-05-02 Thread Emmanuel Bernard
I am not certain everyone follows all pull request notifications so that might explain the lack. At least in the "NoORM" subteam (search, OGM, Validator) we should handle pull requests for all of these projects even if its not "our" project du jour. On 1 mai 2013, at 19:49, Gunnar Morling wro

Re: [hibernate-dev] Relaxing the pull request review requirement

2013-05-01 Thread Gunnar Morling
At least in HV we've been doing this effectively already, e.g. fixed typos without creating a PR. In particular when doing a review of a PR, merging this and adding another commit with this sort of tiny fixes, without creating a new PR for this. So I think this makes sense in some situtations, but

[hibernate-dev] Relaxing the pull request review requirement

2013-05-01 Thread Sanne Grinovero
We have been generally very strict in requiring any code change to be reviewed by someone else; I still believe this has many benefits, but also it brings occasionally to painfully slow integrations for trivial fixed. Since we have a bot now automatically verifying changes, I think this rule shoul