The downside of waiting for a pull request to be merged by someone else is that it can take away some of the fun of contributing.
Sometimes, I think sequentially and having to wait for a pull request to be merged can hurt my flow. I'm speaking from my experience with non-Hibernate Search projects since I haven't submitted any patches to Search. ;) With Hibernate ORM, I am happy being able to decide myself, whether to push a change or create a pull request for someone else to look at first. I like the ORM model better. On 05/01/2013 12:12 PM, Sanne Grinovero wrote: > We have been generally very strict in requiring any code change to be > reviewed by someone else; > I still believe this has many benefits, but also it brings > occasionally to painfully slow integrations for trivial fixed. > > Since we have a bot now automatically verifying changes, I think this > rule should be relaxed a bit; still highly recommended to wait for > someone else to merge it, but I'd propose that if you're confident it > is simple enough, the review done by the bot should be considered good > enough. > > I just self-merged : > https://github.com/hibernate/hibernate-search/pull/406 > > hope you all agree that waiting for feedback was unnecessary? > > Of course this should be used very sparingly, also considering that > even if you think it's correct and simple enough someone might not > agree with the change, and rises the committer's responsibility to the > highest level. > > Sanne > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
