+1
On Fri, Dec 6, 2013 at 1:15 PM, Sanne Grinovero wrote:
> Hi all,
> sorry was traveling yesterday, and while I saw & merged Guillaume's
> pull request, I missed this conversation.
>
> We can to an Hibernate Search 4.4 minor release, would that resolve
> all uncomforts?
>
> The release blog woul
+1 Sounds reasonable.
2013/12/6 Sanne Grinovero
> Hi all,
> sorry was traveling yesterday, and while I saw & merged Guillaume's
> pull request, I missed this conversation.
>
> We can to an Hibernate Search 4.4 minor release, would that resolve
> all uncomforts?
>
> The release blog would then a
Hi all,
sorry was traveling yesterday, and while I saw & merged Guillaume's
pull request, I missed this conversation.
We can to an Hibernate Search 4.4 minor release, would that resolve
all uncomforts?
The release blog would then also be an appropriate medium to warn
about the incompatibility.
S
Is there any decision taken about this?
I find the situation to have 2 major Hibernate components incompatible
after an upgrade to a point release a bit uncomfortable.
The cleanest way to fix it is probably to build a point release of
Search but if it's too much work, maybe we should just communi
On Thu, Dec 5, 2013 at 5:31 PM, Guillaume Smet wrote:
> I'm working on a pull request to fix the problem in search as
> requested by Steve.
Done: https://github.com/hibernate/hibernate-search/pull/521
--
Guillaume
___
hibernate-dev mailing list
hibern
-
> From: "Guillaume Smet"
> To: "Scott Marlow"
> Cc: "Hibernate"
> Sent: Thursday, December 5, 2013 11:09:42 AM
> Subject: Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and
> thus HSearch
>
> Yes. This commit looks really nice
er
Red Hat, Hibernate ORM
- Original Message -
From: "Guillaume Smet"
To: "Scott Marlow"
Cc: "Hibernate"
Sent: Thursday, December 5, 2013 11:09:42 AM
Subject: Re: [hibernate-dev] ORM 4.2.8.Final breaks the EntityKey API and
thus HSearch
Yes. This com
Can't (read you should be!) you use
org.hibernate.engine.spi.SessionImplementor#generateEntityKey ?
Its signature hides the values from Session actually kept on the
genernated EntityKey:
public EntityKey generateEntityKey(Serializable id, EntityPersister
persister);
That signature has not ch
Yes. This commit looks really nice: that's what looks really
interesting to me in 4.2.8. But providing a compatibility layer seems
necessary.
On Thu, Dec 5, 2013 at 5:06 PM, Scott Marlow wrote:
> Looks like this commit changed that
> https://github.com/hibernate/hibernate-orm/commit/bf26311474257
Looks like this commit changed that
https://github.com/hibernate/hibernate-orm/commit/bf26311474257c2f0118615e003553095c2d87b0
On 12/05/2013 10:51 AM, Guillaume Smet wrote:
> Hi all,
>
> ORM 4.2.8.Final breaks the API of EntityKey as it removes tenantId
> from the constructor.
>
> Typically, in H
Hi all,
ORM 4.2.8.Final breaks the API of EntityKey as it removes tenantId
from the constructor.
Typically, in HSearch, we have the following call:
https://github.com/hibernate/hibernate-search/blob/master/orm/src/main/java/org/hibernate/search/query/hibernate/impl/PersistenceContextObjectsInitia
11 matches
Mail list logo
