[hibernate-dev] Javadocs for Hibernate 6.0 contains docs for classes that no longer exists

2022-04-26 Thread Mark Rotteveel
x27;t cleaned out. Also, on https://hibernate.org/orm/releases/6.0/, the javadoc link goes to https://docs.jboss.org/hibernate/stable/orm/javadocs/ which is for 5.5.9.Final, not 6.0. Do you want me to raise a ticket, or is this sufficient? Mark -- Mark Rott

[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-09 Thread Mark Rotteveel
Mark On 07-03-2021 16:29, Mark Rotteveel wrote: Testing against Firebird, it seems like Dialect.supportsValuesList() is ignored. Specifically the test org.hibernate.orm.test.query.hql.InsertUpdateTests.testInsertValues generates the following statement even with Dialect.supportsValuesList

[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-08 Thread Mark Rotteveel
ities as well as for cascades. -- Mark Rotteveel ___ hibernate-dev mailing list -- hibernate-dev@lists.jboss.org To unsubscribe send an email to hibernate-dev-le...@lists.jboss.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-08 Thread Mark Rotteveel
hink about it a little though. -- Mark Rotteveel ___ hibernate-dev mailing list -- hibernate-dev@lists.jboss.org To unsubscribe send an email to hibernate-dev-le...@lists.jboss.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[hibernate-dev] Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-07 Thread Mark Rotteveel
Ticket (id, ticket_key, subject, details) values (2, 'XYZ123', 'Outage', 'Something is broken'), ( 13, 'HIJ456', 'x', 'x' ) ``` Or is this a situation where this is ignored because the

[hibernate-dev] Re: Query generated for insert ... select

2021-03-06 Thread Mark Rotteveel
oot. I'll fix that on Monday. Mark Rotteveel mailto:m...@lawinegevaar.nl>> schrieb am Sa., 6. März 2021, 11:01: For an INSERT ... SELECT, Hibernate (in wip/6.0) will generate a SQL statement with parentheses around the select statement. This happens in AbstractSqlAstT

[hibernate-dev] Query generated for insert ... select

2021-03-06 Thread Mark Rotteveel
when processing a select in an insert statement (I think; there are some other places where Firebird doesn't support parenthesized selects where the standard does). Mark -- Mark Rotteveel ___ hibernate-dev mailing list -- hibernate-dev@lists.jb

[hibernate-dev] List of keywords in AnsiSqlKeywords.java incomplete

2021-03-06 Thread Mark Rotteveel
last option would have compatibility consequences (as additional keywords may get quoted, which could change case-sensitivity for some databases), so that may not be desirable. Your thoughts on this? Mark -- Mark Rotteveel ___ hibernate-dev mailing

Re: [hibernate-dev] Which branch to target?

2019-06-29 Thread Mark Rotteveel
On 29-6-2019 14:49, Mark Rotteveel wrote: > On 21-6-2019 17:09, Mark Rotteveel wrote: >> On 2019-06-19 12:12, Sanne Grinovero wrote: >>> As far as I know branch wip/6.0 is a bit in flux ATM, so it might be >>> safer to just target master. >>> Or send them to

Re: [hibernate-dev] Which branch to target?

2019-06-29 Thread Mark Rotteveel
On 21-6-2019 17:09, Mark Rotteveel wrote: > On 2019-06-19 12:12, Sanne Grinovero wrote: >> As far as I know branch wip/6.0 is a bit in flux ATM, so it might be >> safer to just target master. >> Or send them to both if that's easy for you? > > I can probably do

Re: [hibernate-dev] Test FormulaWithPartitionByTest seems to rely on implementation specific ordering

2019-06-26 Thread Mark Rotteveel
On 2019-06-24 17:53, Steve Ebersole wrote: > The query is selecting ids, so I assume you mean `1,2,3` as the > expectation. The test is asserting the result of `ROW_NUMBER() OVER( PARTITION BY DISCOUNT_CODE ORDER BY SIGN(DISCOUNT_VALUE) DESC )`, and given the `ORDER BY SIGN(DISCOUNT_VALUE) DESC`

[hibernate-dev] Test FormulaWithPartitionByTest seems to rely on implementation specific ordering

2019-06-22 Thread Mark Rotteveel
is consistent with the data: ORDER BY DISCOUNT_VALUE (the use of SIGN with the shown data can lead to an arbitrary order as the result is always 1). What would have your preference? Mark -- Mark Rotteveel ___ hibernate-dev mailing list

Re: [hibernate-dev] Which branch to target?

2019-06-21 Thread Mark Rotteveel
On 2019-06-19 12:12, Sanne Grinovero wrote: > On Tue, 18 Jun 2019 at 14:19, Mark Rotteveel > wrote: >> >> On 16-6-2019 16:28, Mark Rotteveel wrote: >> > After a significant hiatus, I have restarted my work on adding improved >> > support for Firebird 2.5 and

Re: [hibernate-dev] Which branch to target?

2019-06-18 Thread Mark Rotteveel
On 16-6-2019 16:28, Mark Rotteveel wrote: > After a significant hiatus, I have restarted my work on adding improved > support for Firebird 2.5 and 3.0 (and more importantly struggling > through some test failures). > > I am wondering what I should target for my changes: the

[hibernate-dev] Which branch to target?

2019-06-16 Thread Mark Rotteveel
preferred or 'better' option? Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Should the LocalTimeType use the globally configured TimeZone?

2018-10-05 Thread Mark Rotteveel
again implies a choice of time zone). Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Async JDBC proposal

2018-03-20 Thread Mark Rotteveel
ink to, > but it's the most recent presentation on the topic I'm aware of: > > > https://blogs.oracle.com/java/jdbc-next%3a-a-new-asynchronous-api-for-connecting-to-a-database > > --Gunnar > > 2018-03-20 19:09 GMT+01:00 Mark Rotteveel : > >> Minor nitpi

Re: [hibernate-dev] Async JDBC proposal

2018-03-20 Thread Mark Rotteveel
Minor nitpick, the proposed asynchronous database API (ADBA) is not part of JDBC, nor does it rely on or use JDBC (or at least implementations doing that wouldn't be truely async). Mark PS Could you send the actual link? On 2018-03-20 12:01, Emmanuel Bernard wrote: > Nothing really new for peo

[hibernate-dev] Problems with PreparedStatementSpyConnectionProvider

2017-09-10 Thread Mark Rotteveel
Has anyone seen this before, and what can I do to address this? Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Are the tests in the documentation module expected to run on MySQL only?

2017-09-09 Thread Mark Rotteveel
pForDialect instead for now. I might revisit that decision at a later date. Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Are the tests in the documentation module expected to run on MySQL only?

2017-09-08 Thread Mark Rotteveel
On 2017-09-08 20:23, Vlad Mihalcea wrote: > I test Hibernate with the following DBs mostly: > > - H2 > - Oracle > - SQL Server > - PostgreSQL > - MySQL and MariaDb > > For other databases, it's not guaranteed that all tests will run. > > Related to that function, we could other add a change, but

[hibernate-dev] Are the tests in the documentation module expected to run on MySQL only?

2017-09-08 Thread Mark Rotteveel
r used in Hibernate tests, so I wonder if this would need to be handled elsewhere. What to do? Do I ignore the documentation tests, add an exception for Firebird or create a pull request with the above change, or something else? -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
On 11-2-2017 16:10, Mark Rotteveel wrote: > On 11-2-2017 15:56, Vlad Mihalcea wrote: >> Hi Mark, >> >> Good catch. We should change it to 1, instead of 0. > > I created https://hibernate.atlassian.net/browse/HHH-11482, will post a > PR later (hopefully this

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
On 11-2-2017 15:56, Vlad Mihalcea wrote: > Hi Mark, > > Good catch. We should change it to 1, instead of 0. I created https://hibernate.atlassian.net/browse/HHH-11482, will post a PR later (hopefully this weekend). Mark -- Mark

[hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
tion to specify that start position is 1-based? Or is there a specific reason this example uses 0? Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Yes, it is the jdk9 job. Sorry, that I forgot to include that info. Mark - Bericht beantwoorden - Van: "Steve Ebersole" Aan: "Mark Rotteveel" , "Sanne Grinovero" CC: "Hibernate.org" Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Thanks! I just received a build failure notification with an ExceptionInInitialiserError, but I can't see how my PR would introduce that error. Any idea, or should I just ignore it? Mark - Bericht beantwoorden - Van: "Sanne Grinovero" Aan: "Mark Rotteveel&

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Issue: https://hibernate.atlassian.net/browse/HHH-11467 PR: https://github.com/hibernate/hibernate-orm/pull/1781 On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE b

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
+ PR, I can do that as well. Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-07 Thread Mark Rotteveel
Any comments, or should I take the lack of answers as approval ;) Mark On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE between > conditions (specif

[hibernate-dev] Form-feed (\f 0x0C) in generated SQL

2017-02-04 Thread Mark Rotteveel
) with a single space (or maybe with " \n\t" to produce more similar SQL as previous)? Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] When is Dialect.requiresCastingOfParametersInSelectClause applied?

2017-01-31 Thread Mark Rotteveel
One example: when a test uses sequences, you need to use a DialectCheck > because otherwise it will fail on MySQL. Thanks, I will work through the failures one by one then and see if they can work for Firebird or not. Mark -- Mark Rotteveel ___ hibe

[hibernate-dev] When is Dialect.requiresCastingOfParametersInSelectClause applied?

2017-01-30 Thread Mark Rotteveel
oCdiAvailableTest, XmlAccessTest, FetchProfileTest, IndexTest and some others). -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

2016-07-30 Thread Mark Rotteveel
to the InterbaseDialect and FirebirdDialect. > I'd also suggest we properly deprecate Dialect#supportsPooledSequences, > Dialect#getCreateSequenceStrings directing to Dialect#getSequenceExporter. The problem with that is that the StandardSequenceExporter uses getCreateSequenceStrings

Re: [hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

2016-07-29 Thread Mark Rotteveel
On 2016-07-28 17:07, Steve Ebersole wrote: > I do think this is an error.  I think the proper fix is to first > make use of Exporter#getSqlCreateStrings via > Dialect#getSequenceExporter.   > > From there, either: > > * Change the standard Exporter to look at > Dialect#supportsPooledSequences

Re: [hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

2016-07-28 Thread Mark Rotteveel
On 28-7-2016 13:02, Vlad Mihalcea wrote: > Is it that you get the exception even if the incrementSize is 1? I guess > this is an issue that we need to open a Jira ticket for it. Yes, see the code in my initial email: SchemaCreatorImpl always tries to create a pooled sequence. Mark --

Re: [hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

2016-07-28 Thread Mark Rotteveel
be used for that, but as far as I can tell the current support for pooled sequences seems to require specifying the increment size in the sequence DDL, which is not supported by Firebird. Is there a specific extension point to override this, is it the getDefaultMultiTableBulkIdStrategy()? Mark --

[hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

2016-07-28 Thread Mark Rotteveel
nceStrings( jdbcEnvironment.getQualifiedObjectNameFormatter().format( sequence.getName(), dialect ) ), Kind regards, Mark Rotteveel -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev