Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-09-04 Thread Steve Ebersole
Stepping through the code showed me that PropertyHolder#addProperty will not be useful here. Its called after the corresponding SimpleValueBinder#setType call. Really not understanding how these are intended to work. I have some of the normalization working, hooked into PropertyHolder construc

[hibernate-dev] HCANN release protocol

2013-09-04 Thread Steve Ebersole
What is the proper way to release hibernate-commons-annotations? Do we just use Maven release plugin? ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-09-04 Thread Steve Ebersole
I am still a bit confused on how to apply the normalization to make sure it happens in the proper order. Let's look at: @Entity class Person { ... @Embedded @Convert( attributeName="city", converter=Converter2.class ) public Address homeAddress; } @Embeddable class Address

Re: [hibernate-dev] HCANN release protocol

2013-09-04 Thread Hardy Ferentschik
Right, maven release plugin. I guess the build could need some love, but as I keep saying we would be better off phasing out its use. --Hardy On 4 Jan 2013, at 11:08 PM, Brett Meyer wrote: > Last time I did it, I believe that was true -- Maven release plugin only. > > Although, I thought you

Re: [hibernate-dev] HCANN release protocol

2013-09-04 Thread Brett Meyer
Last time I did it, I believe that was true -- Maven release plugin only. Although, I thought you mentioned that you'd migrate commons-annotations to Gradle while you were in the area ;) - Original Message - From: "Steve Ebersole" To: "hibernate-dev" Sent: Wednesday, September 4, 2013

Re: [hibernate-dev] Hibernate Search compatibility with ORM 4.3

2013-09-04 Thread Sanne Grinovero
To better explain the SessionDelegatorBaseImpl approach, I guess this patch is worth 1000 words: https://github.com/Sanne/hibernate-search/commit/a5dceffba58a1ea6a820e7fa5e11ecdffd079b96 7 additions and 704 deletions: that's a good improvement :-) The real benefit is however in the strong decoup

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Gunnar Morling
2013/9/4 Hardy Ferentschik > > On 3 Jan 2013, at 4:10 PM, Emmanuel Bernard > wrote: > > > Something like c makes sense. > > It similar to the notion of converter in JPA. > > > > But why not the following style of interfaces > > > >interface Convert { > >To convert(From); > >} > >

Re: [hibernate-dev] Hibernate Search compatibility with ORM 4.3

2013-09-04 Thread Sanne Grinovero
That's one possibility, but to recap all options discussed so far: One alternative which I consider quite tempting is that we don't implement the new methods defined in Session and EntityManager (JPA 2.1), but keeping it fully compatible in all other ways. We have this option because I resolved a

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Hardy Ferentschik
On 3 Jan 2013, at 4:10 PM, Emmanuel Bernard wrote: > Something like c makes sense. > It similar to the notion of converter in JPA. > > But why not the following style of interfaces > >interface Convert { >To convert(From); >} Going back to Emmanuel mentioning @Convert. I am

Re: [hibernate-dev] Hibernate Search compatibility with ORM 4.3

2013-09-04 Thread Gunnar Morling
One option would be to (temporarily) establish an abstraction layer in HSEARCH, which provides a uniform way for accessing the concerned functionality from ORM. You would then have two implementations of this layer, one based on 4.2 and one based on 4.3 (e.g. in form of two separate HSEARCH module

[hibernate-dev] Hibernate Search compatibility with ORM 4.3

2013-09-04 Thread Sanne Grinovero
There are some small changes in ORM 4.3 which are making HSearch incompatible, while I'm trying to keep Search compatible with bith ORM 4.2.x and 4.3 series. It's more complex than expected, so here is an update on what I'm doing: # Shadowing of interfaces being moved to new packages One change

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Hardy Ferentschik
> Another use case may be Optional from JDK 8: > > @Size(min = 5) > Optional name; Is another upcoming change not "type annotations" which would allow Optional<@Size(min = 5) String>? That would of course be the preferable solution. --hardy

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Gunnar Morling
2013/9/4 Emmanuel Bernard > On Wed 2013-09-04 9:26, Gunnar Morling wrote: > > 2013/9/4 Emmanuel Bernard > > > > > On Wed 2013-09-04 8:27, Gunnar Morling wrote: > > > > 2013/9/3 Emmanuel Bernard > > > > > > > > > Something like c makes sense. > > > > > > > > > > > > > Ok. > > > > > > > > > > >

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Emmanuel Bernard
On Wed 2013-09-04 9:26, Gunnar Morling wrote: > 2013/9/4 Emmanuel Bernard > > > On Wed 2013-09-04 8:27, Gunnar Morling wrote: > > > 2013/9/3 Emmanuel Bernard > > > > > > > Something like c makes sense. > > > > > > > > > > Ok. > > > > > > > > > > It similar to the notion of converter in JPA. >

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Gunnar Morling
2013/9/4 Emmanuel Bernard > On Wed 2013-09-04 8:27, Gunnar Morling wrote: > > 2013/9/3 Emmanuel Bernard > > > > > Something like c makes sense. > > > > > > > Ok. > > > > > > > It similar to the notion of converter in JPA. > > > > > > But why not the following style of interfaces > > > > > >

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Gunnar Morling
2013/9/4 Gunnar Morling > (using correct list now) > > > 2013/9/3 Hardy Ferentschik > >> >> >> >> >> On 3 Sep 2013, at 15:58, Gunnar Morling wrote: >> >> > Hi, >> > >> > Yesterday George Gastaldi from the Forge team approached me regarding >> the >> > application of constraints to "wrapped" pro

Re: [hibernate-dev] [Validator] Applying constraints to property objects

2013-09-04 Thread Emmanuel Bernard
On Wed 2013-09-04 8:27, Gunnar Morling wrote: > 2013/9/3 Emmanuel Bernard > > > Something like c makes sense. > > > > Ok. > > > > It similar to the notion of converter in JPA. > > > > But why not the following style of interfaces > > > > interface Convert { > > To convert(From); >