Re: foreach with error in loop continues

2016-10-11 Thread Paul Smith
On Mon, 2016-10-10 at 20:45 -0700, Emmanuel Mayssat wrote: > > Also you don't escape dollar signs with backslashes inside make, > you > > escape them by writing two dollar signs "$$". > > It turns out I was trying to escape the $(P) and $$(P) did not expend > to anything Right, because $$(P) expa

Re: foreach with error in loop continues

2016-10-10 Thread Emmanuel Mayssat
On 22:19 Mon 10 Oct , Paul Smith wrote: > Also, I don't know why you're passing the "-e" flag multiple times. �It > seems like you are under the impression you need to use it before every > variable assignment on the command line but that's not what -e means. I read the man page and indeed t

Re: foreach with error in loop continues

2016-10-10 Thread Paul Smith
On Mon, 2016-10-10 at 13:50 -0700, Emmanuel Mayssat wrote: > What I noticed is that if the loop fails ($? != 0), foreach still > continues. The loop body of a foreach loop cannot fail.  The foreach function (like most functions in GNU make) doesn't actually run any commands: it performs text subst

foreach with error in loop continues

2016-10-10 Thread Emmanuel Mayssat
Hello, I am running a make with the $(foreach directive. What I noticed is that if the loop fails ($? != 0), foreach still continues. Here is the code: define create_role_targets $(1): -$(MAKE) -e IAM_ROLE_NAME=$(1) _iam_create_role $(foreach P, $(call get_role_policies_R,$(1)), \