[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #24: HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer

2019-10-15 Thread GitBox
xiaoyuyao merged pull request #24: HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer URL: https://github.com/apache/hadoop-ozone/pull/24 This is an automated message from the Apache Git Serv

[GitHub] [hadoop-ozone] jojochuang commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations.

2019-10-15 Thread GitBox
jojochuang commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop-ozone/pull/2#discussion_r335109853 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/fil

[GitHub] [hadoop-ozone] jojochuang commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations.

2019-10-15 Thread GitBox
jojochuang commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop-ozone/pull/2#discussion_r335110340 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/fil

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #14: HDDS-2295. Display log of freon on the standard output

2019-10-15 Thread GitBox
xiaoyuyao merged pull request #14: HDDS-2295. Display log of freon on the standard output URL: https://github.com/apache/hadoop-ozone/pull/14 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #14: HDDS-2295. Display log of freon on the standard output

2019-10-15 Thread GitBox
xiaoyuyao commented on a change in pull request #14: HDDS-2295. Display log of freon on the standard output URL: https://github.com/apache/hadoop-ozone/pull/14#discussion_r335114183 ## File path: hadoop-ozone/common/src/main/bin/ozone ## @@ -124,7 +124,7 @@ function ozonec

[GitHub] [hadoop-ozone] adoroszlai commented on issue #7: HDDS-1228. Chunk Scanner Checkpoints

2019-10-15 Thread GitBox
adoroszlai commented on issue #7: HDDS-1228. Chunk Scanner Checkpoints URL: https://github.com/apache/hadoop-ozone/pull/7#issuecomment-542352309 @arp7 thanks for the comments on the original PR. I've updated this one to use `Optional`, and while there, use `Instant` instead of `Long` to ma

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #30: HDDS-1988. Fix listParts API.

2019-10-15 Thread GitBox
bharatviswa504 opened a new pull request #30: HDDS-1988. Fix listParts API. URL: https://github.com/apache/hadoop-ozone/pull/30 https://issues.apache.org/jira/browse/HDDS-1988 We don't need any fix for List Parts API, as the information of all uploaded parts is stored as key-value in

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #31: HDDS-2254 : Fix flaky unit test TestContainerStateMachine#testRatisSn…

2019-10-15 Thread GitBox
avijayanhwx opened a new pull request #31: HDDS-2254 : Fix flaky unit test TestContainerStateMachine#testRatisSn… URL: https://github.com/apache/hadoop-ozone/pull/31 …apshotRetention. ## What changes were proposed in this pull request? On locally trying out repeated runs of the un

[GitHub] [hadoop-ozone] xiaoyuyao opened a new pull request #32: Revert "HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer"

2019-10-15 Thread GitBox
xiaoyuyao opened a new pull request #32: Revert "HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer" URL: https://github.com/apache/hadoop-ozone/pull/32 Reverts apache/hadoop-ozone#24 This is

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #32: Revert "HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer"

2019-10-15 Thread GitBox
xiaoyuyao merged pull request #32: Revert "HDDS 2181. Ozone Manager should send correct ACL type in ACL requests to Authorizer" URL: https://github.com/apache/hadoop-ozone/pull/32 This is an automated message from the Apache

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #33: Hdds 1985

2019-10-15 Thread GitBox
bharatviswa504 opened a new pull request #33: Hdds 1985 URL: https://github.com/apache/hadoop-ozone/pull/33 https://issues.apache.org/jira/browse/HDDS-1985 No fix is required for this, as the information is retrieved from the MPU Key table, this information is not retrieved through R

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #34: HDDS-2312. Fix typo in ozone command

2019-10-15 Thread GitBox
adoroszlai opened a new pull request #34: HDDS-2312. Fix typo in ozone command URL: https://github.com/apache/hadoop-ozone/pull/34 ## What changes were proposed in this pull request? Trivial typo fix. https://issues.apache.org/jira/browse/HDDS-2312 ## How was this patch

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest

2019-10-15 Thread GitBox
adoroszlai opened a new pull request #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest URL: https://github.com/apache/hadoop-ozone/pull/35 ## What changes were proposed in this pull request? Fix duplicate release of lock (apparently a merge issue, the original change (

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #34: HDDS-2312. Fix typo in ozone command

2019-10-15 Thread GitBox
avijayanhwx commented on issue #34: HDDS-2312. Fix typo in ozone command URL: https://github.com/apache/hadoop-ozone/pull/34#issuecomment-542531167 LGTM +1 This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations.

2019-10-15 Thread GitBox
cxorm commented on a change in pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop-ozone/pull/2#discussion_r335291642 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/Tes

[GitHub] [hadoop-ozone] cxorm opened a new pull request #36: HDDS-2314. Fix TestOMKeyCommitRequest Error.

2019-10-16 Thread GitBox
cxorm opened a new pull request #36: HDDS-2314. Fix TestOMKeyCommitRequest Error. URL: https://github.com/apache/hadoop-ozone/pull/36 **### What changes were proposed in this pull request?** Fix the acquire/release lock in OMKeyCommitRequest.java

[GitHub] [hadoop-ozone] cxorm closed pull request #36: HDDS-2314. Fix TestOMKeyCommitRequest Error.

2019-10-16 Thread GitBox
cxorm closed pull request #36: HDDS-2314. Fix TestOMKeyCommitRequest Error. URL: https://github.com/apache/hadoop-ozone/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hadoop-ozone] mukul1987 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
mukul1987 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335388484 ## File path: hadoop-hdds/container-service/src/main/java/

[GitHub] [hadoop-ozone] mukul1987 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
mukul1987 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335387189 ## File path: hadoop-hdds/container-service/src/main/java/

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #37: HDDS-2197 Extend SCMCLI Topology command to print node Operational States

2019-10-16 Thread GitBox
sodonnel opened a new pull request #37: HDDS-2197 Extend SCMCLI Topology command to print node Operational States URL: https://github.com/apache/hadoop-ozone/pull/37 The scmcli topology command only consider the node health (healthy, stale or dead). With decommission and maintenance stages

[GitHub] [hadoop-ozone] elek closed pull request #30: HDDS-1988. Fix listParts API.

2019-10-16 Thread GitBox
elek closed pull request #30: HDDS-1988. Fix listParts API. URL: https://github.com/apache/hadoop-ozone/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop-ozone] elek opened a new pull request #38: github-actions

2019-10-16 Thread GitBox
elek opened a new pull request #38: github-actions URL: https://github.com/apache/hadoop-ozone/pull/38 github actions test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335307601 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pip

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335305877 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/pl

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335377568 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pip

[GitHub] [hadoop-ozone] elek closed pull request #38: github-actions

2019-10-16 Thread GitBox
elek closed pull request #38: github-actions URL: https://github.com/apache/hadoop-ozone/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335382664 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Rat

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335399342 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipel

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335379816 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Rat

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335304602 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.ja

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335399857 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipel

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335401278 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzon

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335326566 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCM

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335305442 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.xml ## @@ -846,

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
ChenSammi commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335323752 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCM

[GitHub] [hadoop-ozone] elek commented on issue #8: HDDS-2267. Container metadata scanner interval mismatch

2019-10-16 Thread GitBox
elek commented on issue #8: HDDS-2267. Container metadata scanner interval mismatch URL: https://github.com/apache/hadoop-ozone/pull/8#issuecomment-542646488 My previous comments are not addressed but it was an optional suggestion. I commit it right now as it's better than the current code

[GitHub] [hadoop-ozone] elek closed pull request #8: HDDS-2267. Container metadata scanner interval mismatch

2019-10-16 Thread GitBox
elek closed pull request #8: HDDS-2267. Container metadata scanner interval mismatch URL: https://github.com/apache/hadoop-ozone/pull/8 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop-ozone] elek commented on issue #33: HDDS-1985. Fix listVolumes API

2019-10-16 Thread GitBox
elek commented on issue #33: HDDS-1985. Fix listVolumes API URL: https://github.com/apache/hadoop-ozone/pull/33#issuecomment-542650094 Merged in 5adf6a1e3175e2a583eea0d2384ed1f8e11da57b This is an automated message from the Ap

[GitHub] [hadoop-ozone] elek removed a comment on issue #33: HDDS-1985. Fix listVolumes API

2019-10-16 Thread GitBox
elek removed a comment on issue #33: HDDS-1985. Fix listVolumes API URL: https://github.com/apache/hadoop-ozone/pull/33#issuecomment-542650094 Merged in 5adf6a1e3175e2a583eea0d2384ed1f8e11da57b This is an automated message fro

[GitHub] [hadoop-ozone] elek closed pull request #33: HDDS-1985. Fix listVolumes API

2019-10-16 Thread GitBox
elek closed pull request #33: HDDS-1985. Fix listVolumes API URL: https://github.com/apache/hadoop-ozone/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop-ozone] elek commented on issue #33: HDDS-1985. Fix listVolumes API

2019-10-16 Thread GitBox
elek commented on issue #33: HDDS-1985. Fix listVolumes API URL: https://github.com/apache/hadoop-ozone/pull/33#issuecomment-542650306 Oh, sorry I am confused. This is the listVolume. I accidentally close it. This is an automa

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #33: HDDS-1985. Fix listVolumes API

2019-10-16 Thread GitBox
bharatviswa504 opened a new pull request #33: HDDS-1985. Fix listVolumes API URL: https://github.com/apache/hadoop-ozone/pull/33 https://issues.apache.org/jira/browse/HDDS-1985 No fix is required for this, as the information is retrieved from the MPU Key table, this information is no

[GitHub] [hadoop-ozone] adoroszlai commented on issue #8: HDDS-2267. Container metadata scanner interval mismatch

2019-10-16 Thread GitBox
adoroszlai commented on issue #8: HDDS-2267. Container metadata scanner interval mismatch URL: https://github.com/apache/hadoop-ozone/pull/8#issuecomment-542651011 Thanks @xiaoyuyao for the review. Thanks @elek for reviewing and committing it. I like your idea about using type-safe time

[GitHub] [hadoop-ozone] elek closed pull request #34: HDDS-2312. Fix typo in ozone command

2019-10-16 Thread GitBox
elek closed pull request #34: HDDS-2312. Fix typo in ozone command URL: https://github.com/apache/hadoop-ozone/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop-ozone] adoroszlai commented on issue #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest

2019-10-16 Thread GitBox
adoroszlai commented on issue #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest URL: https://github.com/apache/hadoop-ozone/pull/35#issuecomment-542666371 Fixed by revert: 17081c2e This is an automated message f

[GitHub] [hadoop-ozone] adoroszlai closed pull request #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest

2019-10-16 Thread GitBox
adoroszlai closed pull request #35: HDDS-2313. Duplicate release of lock in OMKeyCommitRequest URL: https://github.com/apache/hadoop-ozone/pull/35 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hadoop-ozone] elek opened a new pull request #39: HDDS-2316. Support to skip recon and/or ozonefs during the build

2019-10-16 Thread GitBox
elek opened a new pull request #39: HDDS-2316. Support to skip recon and/or ozonefs during the build URL: https://github.com/apache/hadoop-ozone/pull/39 ## What changes were proposed in this pull request? The two slowest part of Ozone build as of now: * The (multiple) sha

[GitHub] [hadoop-ozone] elek commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster.

2019-10-16 Thread GitBox
elek commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster. URL: https://github.com/apache/hadoop-ozone/pull/27#issuecomment-542677319 /retest This is an automated message from the Apache Git Service. To respon

[GitHub] [hadoop-ozone] elek commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster.

2019-10-16 Thread GitBox
elek commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster. URL: https://github.com/apache/hadoop-ozone/pull/27#issuecomment-542677287 UPDATE: it's failing during my local test all the time. the ozones3 is working but not the new tests. Let's try to request a new test run...

[GitHub] [hadoop-ozone] elek closed pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations.

2019-10-16 Thread GitBox
elek closed pull request #2: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop-ozone/pull/2 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hadoop-ozone] elek commented on issue #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn…

2019-10-16 Thread GitBox
elek commented on issue #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn… URL: https://github.com/apache/hadoop-ozone/pull/31#issuecomment-542694071 Thanks the PR @avijayanhwx. As far as I see it includes additional commits. Can you please try to rebase it to remov

[GitHub] [hadoop-ozone] anuengineer commented on issue #39: HDDS-2316. Support to skip recon and/or ozonefs during the build

2019-10-16 Thread GitBox
anuengineer commented on issue #39: HDDS-2316. Support to skip recon and/or ozonefs during the build URL: https://github.com/apache/hadoop-ozone/pull/39#issuecomment-542712298 Thank you for getting this done. Appreciate it. --

[GitHub] [hadoop-ozone] anuengineer merged pull request #39: HDDS-2316. Support to skip recon and/or ozonefs during the build

2019-10-16 Thread GitBox
anuengineer merged pull request #39: HDDS-2316. Support to skip recon and/or ozonefs during the build URL: https://github.com/apache/hadoop-ozone/pull/39 This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop-ozone] cxorm commented on issue #2: HDDS-1737. Add Volume check in KeyManager and File Operations.

2019-10-16 Thread GitBox
cxorm commented on issue #2: HDDS-1737. Add Volume check in KeyManager and File Operations. URL: https://github.com/apache/hadoop-ozone/pull/2#issuecomment-542723039 Thanks @bharatviswa504 and @jojochuang for the review. Thanks @elek for the commit. -

[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335553429 ## File path: hadoop-hdds/container-service/src/main/j

[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335533998 ## File path: hadoop-hdds/server-scm/src/main/java/org

[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
nandakumar131 commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335543661 ## File path: hadoop-hdds/container-service/src/main/j

[GitHub] [hadoop-ozone] avijayanhwx closed pull request #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn…

2019-10-16 Thread GitBox
avijayanhwx closed pull request #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn… URL: https://github.com/apache/hadoop-ozone/pull/31 This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn…

2019-10-16 Thread GitBox
avijayanhwx opened a new pull request #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn… URL: https://github.com/apache/hadoop-ozone/pull/31 …apshotRetention. ## What changes were proposed in this pull request? On locally trying out repeated runs of the uni

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn…

2019-10-16 Thread GitBox
avijayanhwx commented on issue #31: HDDS-2254. Fix flaky unit test TestContainerStateMachine#testRatisSn… URL: https://github.com/apache/hadoop-ozone/pull/31#issuecomment-542797782 > Thanks the PR @avijayanhwx. As far as I see it includes additional commits. Can you please try to rebase it

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster.

2019-10-16 Thread GitBox
bharatviswa504 commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster. URL: https://github.com/apache/hadoop-ozone/pull/27#issuecomment-542799585 Thank You @elek for the review. I see newly acceptance tests are passing. Let me know if you still see errors in your local ru

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster.

2019-10-16 Thread GitBox
bharatviswa504 commented on issue #27: HDDS-2278. Run S3 test suite on OM HA cluster. URL: https://github.com/apache/hadoop-ozone/pull/27#issuecomment-542800119 > +1 thanks the patch @bharatviswa504 > > Note: While I am happy to have more and more environments, I feel that it's hard

[GitHub] [hadoop-ozone] hanishakoneru opened a new pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s…

2019-10-16 Thread GitBox
hanishakoneru opened a new pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40 It can be observed that the GetBlock and ReadChunk command is sent to 2 different datanodes. It should be sent to the same

[GitHub] [hadoop-ozone] swagle opened a new pull request #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation.

2019-10-16 Thread GitBox
swagle opened a new pull request #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation. URL: https://github.com/apache/hadoop-ozone/pull/41 Container Creation on datanodes take around 300ms due to rocksdb creation. Rocksdb creation is taking a considerab

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation.

2019-10-16 Thread GitBox
avijayanhwx commented on issue #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation. URL: https://github.com/apache/hadoop-ozone/pull/41#issuecomment-542818462 A good find. LGTM +1 This i

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335654012 ## File path: hadoop-hdds/container-service/src/main/java/org

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335654846 ## File path: hadoop-hdds/container-service/src/main/java/org

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335654846 ## File path: hadoop-hdds/container-service/src/main/java/org

[GitHub] [hadoop-ozone] swagle commented on issue #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

2019-10-16 Thread GitBox
swagle commented on issue #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete. URL: https://github.com/apache/hadoop-ozone/pull/23#issuecomment-542869954 Thank you @mukul1987 and @nandakumar131 for the reviews. --

[GitHub] [hadoop-ozone] anuengineer commented on issue #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation.

2019-10-16 Thread GitBox
anuengineer commented on issue #41: HDDS-2283. Container Creation on datanodes take around 300ms due to rocksdb creation. URL: https://github.com/apache/hadoop-ozone/pull/41#issuecomment-542881435 Can we please use the Ambari inspired template? With info like -- a link to the HDDS J

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #42: Update pull_request_template.md

2019-10-16 Thread GitBox
avijayanhwx opened a new pull request #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42 Update Pull Request Template This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop-ozone] anuengineer commented on issue #42: Update pull_request_template.md

2019-10-16 Thread GitBox
anuengineer commented on issue #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42#issuecomment-542885560 We need a JIRA number to commit anything into the branch. So you will have to file a JIRA and refer to that in the pull request. and it might be a g

[GitHub] [hadoop-ozone] adoroszlai commented on issue #42: Update pull_request_template.md

2019-10-16 Thread GitBox
adoroszlai commented on issue #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42#issuecomment-542887995 This was already done in #5, was it lost during the forced update? This is an automa

[GitHub] [hadoop-ozone] adoroszlai edited a comment on issue #42: Update pull_request_template.md

2019-10-16 Thread GitBox
adoroszlai edited a comment on issue #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42#issuecomment-542887995 This ~was~ is already being done in #5. This is an automated message from the

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #42: Update pull_request_template.md

2019-10-16 Thread GitBox
vivekratnavel commented on issue #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42#issuecomment-542889407 Yes, #5 is not merged yet. We can close this PR and merge #5. This is an automat

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #42: Update pull_request_template.md

2019-10-16 Thread GitBox
avijayanhwx commented on issue #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42#issuecomment-542889556 Thanks @adoroszlai. I will close this. This is an automated message from the Apache

[GitHub] [hadoop-ozone] avijayanhwx closed pull request #42: Update pull_request_template.md

2019-10-16 Thread GitBox
avijayanhwx closed pull request #42: Update pull_request_template.md URL: https://github.com/apache/hadoop-ozone/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #5: HDDS-2289. Put testing information and a problem description to the g…

2019-10-16 Thread GitBox
vivekratnavel commented on issue #5: HDDS-2289. Put testing information and a problem description to the g… URL: https://github.com/apache/hadoop-ozone/pull/5#issuecomment-542889844 +1 LGTM This is an automated message from t

[GitHub] [hadoop-ozone] anuengineer merged pull request #5: HDDS-2289. Put testing information and a problem description to the g…

2019-10-16 Thread GitBox
anuengineer merged pull request #5: HDDS-2289. Put testing information and a problem description to the g… URL: https://github.com/apache/hadoop-ozone/pull/5 This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop-ozone] anuengineer commented on issue #21: HDDS-2302. Manage common pom versions in one common place

2019-10-16 Thread GitBox
anuengineer commented on issue #21: HDDS-2302. Manage common pom versions in one common place URL: https://github.com/apache/hadoop-ozone/pull/21#issuecomment-542933249 Thank you for the contribution. I have committed this patch to the master. --

[GitHub] [hadoop-ozone] anuengineer closed pull request #21: HDDS-2302. Manage common pom versions in one common place

2019-10-16 Thread GitBox
anuengineer closed pull request #21: HDDS-2302. Manage common pom versions in one common place URL: https://github.com/apache/hadoop-ozone/pull/21 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #43: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-16 Thread GitBox
vivekratnavel opened a new pull request #43: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop-ozone/pull/43 … to Authorizer ## What changes were proposed in this pull request? The ACL types sent to authorizers is chan

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #43: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-10-16 Thread GitBox
vivekratnavel commented on issue #43: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop-ozone/pull/43#issuecomment-542942274 @xiaoyuyao Pls review This is an automate

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335785884 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335791972 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.xml ## @@ -8

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335792190 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335792254 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335792538 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335793270 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-16 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335793351 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] szetszwo opened a new pull request #44: HDDS-2271. Avoid buffer copying in KeyValueHandler.

2019-10-16 Thread GitBox
szetszwo opened a new pull request #44: HDDS-2271. Avoid buffer copying in KeyValueHandler. URL: https://github.com/apache/hadoop-ozone/pull/44 Migrated from https://github.com/apache/hadoop/pull/1625 See https://issues.apache.org/jira/browse/HDDS-2271 --

[GitHub] [hadoop-ozone] szetszwo merged pull request #44: HDDS-2271. Avoid buffer copying in KeyValueHandler.

2019-10-16 Thread GitBox
szetszwo merged pull request #44: HDDS-2271. Avoid buffer copying in KeyValueHandler. URL: https://github.com/apache/hadoop-ozone/pull/44 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop-ozone] szetszwo opened a new pull request #45: HDDS-2275. In BatchOperation.SingleOperation, do not clone byte[].

2019-10-16 Thread GitBox
szetszwo opened a new pull request #45: HDDS-2275. In BatchOperation.SingleOperation, do not clone byte[]. URL: https://github.com/apache/hadoop-ozone/pull/45 See https://issues.apache.org/jira/browse/HDDS-2275 This is an aut

[GitHub] [hadoop-ozone] swagle opened a new pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus…

2019-10-16 Thread GitBox
swagle opened a new pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus… URL: https://github.com/apache/hadoop-ozone/pull/46 ## What changes were proposed in this pull request? Added additional logging to print exclude lists on client and SCM (

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus…

2019-10-16 Thread GitBox
adoroszlai commented on a change in pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus… URL: https://github.com/apache/hadoop-ozone/pull/46#discussion_r335815224 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/serve

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus…

2019-10-16 Thread GitBox
swagle commented on a change in pull request #46: HDDS-2286. Add a log info in ozone client and scm to print the exclus… URL: https://github.com/apache/hadoop-ozone/pull/46#discussion_r335818232 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SC

[GitHub] [hadoop-ozone] supratimdeka opened a new pull request #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka

2019-10-16 Thread GitBox
supratimdeka opened a new pull request #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka URL: https://github.com/apache/hadoop-ozone/pull/47 https://issues.apache.org/jira/browse/HDDS-2208 This is a follow-up to the patch for HD

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-17 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335844551 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pi

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-17 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335846893 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode

2019-10-17 Thread GitBox
timmylicheng commented on a change in pull request #28: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop-ozone/pull/28#discussion_r335847078 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pi

<    2   3   4   5   6   7   8   9   >