swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines
should be marked as ready only after the leader election is complete.
URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335654846
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -107,6 +112,8 @@ private static long nextCallId() {
// TODO: Remove the gids set when Ratis supports an api to query active
// pipelines
private final Set<RaftGroupId> raftGids = new HashSet<>();
+ // pipeline leaders
+ private Map<RaftGroupId, RaftPeerId> leaderIdMap = new HashMap<>();
Review comment:
Yes, I thought about this already and left it HashMap, thinking we would
only get leader changed notification reporting new leaderId, so the updated
value will always be the same from any member. So for a key there will be no
correctness problem. For the sake of caution I can make it CHM but the only way
we get notified a different leaderID will be major correctness issue in Ratis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
