Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-20 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- (Updated 2012-03-20 16:29:56.616292) Review request for hadoop-hdfs and Todd Lip

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-20 Thread Henry Robinson
> On 2012-03-20 01:27:50, Todd Lipcon wrote: > > hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java, > > line 44 > > > > > > shouldn't this be true? Oops, yes. Thankfully the t

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-19 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/#review6103 --- Real close now! hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/ap

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-08 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- (Updated 2012-03-09 00:47:24.765130) Review request for hadoop-hdfs and Todd Lip

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-06 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/#review5665 --- some stuff around error cases here -- I think you'd run into these bug

Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-06 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- Review request for hadoop-hdfs and Todd Lipcon. Summary --- New patch for H