[GitHub] [hadoop-ozone] cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-11-04 Thread GitBox
cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-549252790 > Below are the find bugs that need to be fixed Jenkins reported. > M D DLS: Dead store to result in org.apache.hadoop.ozone.web.ozShell.bucket

[GitHub] [hadoop-ozone] cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-11-04 Thread GitBox
cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-549252790 > Below are the find bugs that need to be fixed Jenkins reported. > M D DLS: Dead store to result in org.apache.hadoop.ozone.web.ozShell

[GitHub] [hadoop-ozone] ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-03 Thread GitBox
ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#issuecomment-549212464 I rerun the failed TestScmSafeMode multiple times locally. All are passed. @xiaoyuyao and @l

[GitHub] [hadoop-ozone] akki opened a new pull request #114: HDDS-1515. Add hadolint checks

2019-11-03 Thread GitBox
akki opened a new pull request #114: HDDS-1515. Add hadolint checks URL: https://github.com/apache/hadoop-ozone/pull/114 ## What changes were proposed in this pull request? Add Hadolint checks ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/H

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes URL: https://github.com/apache/hadoop-ozone/pull/86#discussion_r341825935 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/D

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes URL: https://github.com/apache/hadoop-ozone/pull/86#discussion_r341825865 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/D

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes URL: https://github.com/apache/hadoop-ozone/pull/86#discussion_r341825916 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/D

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #86: HDDS-2329 Destroy pipelines on any decommission or maintenance nodes URL: https://github.com/apache/hadoop-ozone/pull/86#discussion_r341826121 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/D

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#discussion_r341825738 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/t

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#discussion_r341825562 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-02 Thread GitBox
anuengineer commented on a change in pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#discussion_r341825496 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-11-02 Thread GitBox
bharatviswa504 edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-549061100 Below are the find bugs that need to be fixed Jenkins reported. M D DLS: Dead store to result in org.apache.hadoop.ozone.web.o

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-11-02 Thread GitBox
bharatviswa504 commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-549061100 Below are the find bugs that need to be fixed Jenkins reported. M D DLS: Dead store to result in org.apache.hadoop.ozone.web.ozShell.b

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #113: HDDS-2398. Remove usage of LogUtils class from ratis-common.

2019-11-02 Thread GitBox
bharatviswa504 merged pull request #113: HDDS-2398. Remove usage of LogUtils class from ratis-common. URL: https://github.com/apache/hadoop-ozone/pull/113 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #113: HDDS-2398. Remove usage of LogUtils class from ratis-common.

2019-11-02 Thread GitBox
bharatviswa504 commented on issue #113: HDDS-2398. Remove usage of LogUtils class from ratis-common. URL: https://github.com/apache/hadoop-ozone/pull/113#issuecomment-549060188 Thank You @xiaoyuyao for the review. I have committed this to the trunk. -

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-11-02 Thread GitBox
cxorm commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341801796 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java

[GitHub] [hadoop-ozone] xiaoyuyao removed a comment on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-01 Thread GitBox
xiaoyuyao removed a comment on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#issuecomment-549013443 /retest This is an automated messag

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-01 Thread GitBox
xiaoyuyao commented on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#issuecomment-549013443 /retest This is an automated message from t

[GitHub] [hadoop-ozone] cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-11-01 Thread GitBox
cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-549010251 /retest This is an automated message from the Apache Git Service. To respond to t

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #113: HDDS-2398. Remove usage of LogUtils class from ratis-common.

2019-11-01 Thread GitBox
bharatviswa504 opened a new pull request #113: HDDS-2398. Remove usage of LogUtils class from ratis-common. URL: https://github.com/apache/hadoop-ozone/pull/113 ## What changes were proposed in this pull request? Remove usage of LogUtils from ratis-common ## What is the link t

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-11-01 Thread GitBox
xiaoyuyao commented on issue #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110#issuecomment-548941695 /retest This is an automated message from t

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #112: HDDS-2397. Fix calling cleanup for few missing tables in OM.

2019-11-01 Thread GitBox
dineshchitlangia merged pull request #112: HDDS-2397. Fix calling cleanup for few missing tables in OM. URL: https://github.com/apache/hadoop-ozone/pull/112 This is an automated message from the Apache Git Service. To respon

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #112: HDDS-2397. Fix calling cleanup for few missing tables in OM.

2019-11-01 Thread GitBox
avijayanhwx commented on issue #112: HDDS-2397. Fix calling cleanup for few missing tables in OM. URL: https://github.com/apache/hadoop-ozone/pull/112#issuecomment-548859493 LGTM +1 This is an automated message from the Apach

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-11-01 Thread GitBox
avijayanhwx commented on issue #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#issuecomment-548856248 cc @anuengineer This is an autom

[GitHub] [hadoop-ozone] anuengineer commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-11-01 Thread GitBox
anuengineer commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548771319 +1. LGTM. Thanks for the fix. This is an automated message from the Apac

[GitHub] [hadoop-ozone] cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-548683050 > > Thanks @bharatviswa504 for the comment. > > `RemoveAclHandler` updated. > > And I found that > > `ozone sh vol setacl --acls=user:new

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r341455140 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/AddAclBucketHandler.j

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r341191061 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/AddAclBucket

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads

2019-10-31 Thread GitBox
bharatviswa504 edited a comment on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads URL: https://github.com/apache/hadoop-ozone/pull/82#issuecomment-548664326 > Thanks @lokeshj1703 for having a look. The test failure in KeyInputStre

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads

2019-10-31 Thread GitBox
bharatviswa504 commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads URL: https://github.com/apache/hadoop-ozone/pull/82#issuecomment-548664326 > Thanks @lokeshj1703 for having a look. The test failure in KeyInputStream is

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-31 Thread GitBox
dineshchitlangia merged pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51 This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #112: HDDS-2397. Fix calling cleanup for few missing tables in OM.

2019-10-31 Thread GitBox
bharatviswa504 opened a new pull request #112: HDDS-2397. Fix calling cleanup for few missing tables in OM. URL: https://github.com/apache/hadoop-ozone/pull/112 ## What changes were proposed in this pull request? Fix calling clean up of few tables which is missing in OzoneManagerDou

[GitHub] [hadoop-ozone] ChenSammi merged pull request #98: HDDS-2363. Fail to create Ratis container.

2019-10-31 Thread GitBox
ChenSammi merged pull request #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop-ozone] ChenSammi commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-10-31 Thread GitBox
ChenSammi commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548642429 > > > Thanks for working on this @ChenSammi, I cannot understand the changes, How does moving the createIfNeccessary function fixes

[GitHub] [hadoop-ozone] christeoh commented on issue #111: HDDS-2393: Fixing NPE in unit test from HDDS-1847

2019-10-31 Thread GitBox
christeoh commented on issue #111: HDDS-2393: Fixing NPE in unit test from HDDS-1847 URL: https://github.com/apache/hadoop-ozone/pull/111#issuecomment-548613391 /label ozone This is an automated message from the Apache Git Se

[GitHub] [hadoop-ozone] christeoh opened a new pull request #111: Fixed NullPointerException due to constructor calling function that a…

2019-10-31 Thread GitBox
christeoh opened a new pull request #111: Fixed NullPointerException due to constructor calling function that a… URL: https://github.com/apache/hadoop-ozone/pull/111 …ccessed uninitialised object ## What changes were proposed in this pull request? (Please fill in changes propo

[GitHub] [hadoop-ozone] christeoh commented on issue #111: HDDS-2393: Fixing NPE in unit test from HDDS-1847

2019-10-31 Thread GitBox
christeoh commented on issue #111: HDDS-2393: Fixing NPE in unit test from HDDS-1847 URL: https://github.com/apache/hadoop-ozone/pull/111#issuecomment-548613429 /retest This is an automated message from the Apache Git Service

[GitHub] [hadoop-ozone] xiaoyuyao opened a new pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode …

2019-10-31 Thread GitBox
xiaoyuyao opened a new pull request #110: HDDS-2321. Ozone Block Token verify should not apply to all datanode … URL: https://github.com/apache/hadoop-ozone/pull/110 ## What changes were proposed in this pull request? * Change the TokenVerifier interface to check the command type

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #109: HDDS-2395. Handle completeMPU scenarios to match with aws s3 behavior.

2019-10-31 Thread GitBox
bharatviswa504 opened a new pull request #109: HDDS-2395. Handle completeMPU scenarios to match with aws s3 behavior. URL: https://github.com/apache/hadoop-ozone/pull/109 ## What changes were proposed in this pull request? Fix few cases which were missed during complete Multipart upl

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-31 Thread GitBox
xiaoyuyao commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#issuecomment-548591660 /retest since the integration acceptance result is missing. -

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-31 Thread GitBox
hanishakoneru commented on issue #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#issuecomment-548569207 Thank you for the review @dineshchitlangia. Fixed the findbug issue. -

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-31 Thread GitBox
hanishakoneru commented on issue #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#issuecomment-548569243 /retest This is an automated message from th

[GitHub] [hadoop-ozone] anuengineer commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
anuengineer commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#issuecomment-548499340 I have committed this patch to the master branch. @bharatviswa504 Thanks for the

[GitHub] [hadoop-ozone] anuengineer closed pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
anuengineer closed pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102 This is an automated message from the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r341289368 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-31 Thread GitBox
avijayanhwx commented on issue #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#issuecomment-548498718 In this PR, my next commit will fix an issue in the isExist implementation, as discussed in http

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-31 Thread GitBox
avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r341288398 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341287582 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReques

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341287582 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReques

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341286921 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReq

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341286921 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReq

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341285841 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReques

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r341284711 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r341284711 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
dineshchitlangia commented on issue #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#issuecomment-548494975 Thank you all for reviews and @elek for the contribution. Committed this to master.

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341284560 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReques

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
dineshchitlangia merged pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58 This is an automated message from the Apache Git Service. To respon

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r341280362 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341276998 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReq

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r341279366 ## File path: hadoop-ozone/ozone-manager/src/main/ja

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#discussion_r341276998 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientReq

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #11: HDDS-2291. Acceptance tests for OM HA.

2019-10-31 Thread GitBox
hanishakoneru commented on issue #11: HDDS-2291. Acceptance tests for OM HA. URL: https://github.com/apache/hadoop-ozone/pull/11#issuecomment-548488935 The failed integration test is unrelated to this PR. In acceptance tests, the failures are in OzoneSecure suit. Ozone OM HA robot tests

[GitHub] [hadoop-ozone] anuengineer commented on issue #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
anuengineer commented on issue #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#issuecomment-548488617 +1. LGTM. This is an automated message from the Apa

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
avijayanhwx commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r341276117 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop-ozone] jojochuang commented on issue #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
jojochuang commented on issue #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#issuecomment-548482046 +1 This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop-ozone] anuengineer commented on issue #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-31 Thread GitBox
anuengineer commented on issue #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#issuecomment-548461333 @jojochuang The patch looks good to me, if you don't have any more comments, I would like to commit this patch. Thanks in advanc

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
anuengineer commented on a change in pull request #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r341243501 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-31 Thread GitBox
bharatviswa504 commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#issuecomment-548438727 /retest This

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
bharatviswa504 edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-548421656 > Thanks @bharatviswa504 for the comment. > > `RemoveAclHandler` updated. > > And I found that > > `ozone sh

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
bharatviswa504 commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-548421656 > Thanks @bharatviswa504 for the comment. > > `RemoveAclHandler` updated. > > And I found that > > `ozone sh vol seta

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r341191061 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/AddAclBucket

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-31 Thread GitBox
bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r341191061 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/AddAclBucket

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #88: HDDS-2272. Avoid buffer copying in GrpcReplicationClient

2019-10-31 Thread GitBox
bharatviswa504 commented on issue #88: HDDS-2272. Avoid buffer copying in GrpcReplicationClient URL: https://github.com/apache/hadoop-ozone/pull/88#issuecomment-548417031 HDDS-2368 fixed this flakiness in the test. This PR branch does not have the fix, which is in master.

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341186628 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Cont

[GitHub] [hadoop-ozone] cxorm commented on issue #85: HDDS-2219. Move all the ozone dist scripts/configs to one location

2019-10-31 Thread GitBox
cxorm commented on issue #85: HDDS-2219. Move all the ozone dist scripts/configs to one location URL: https://github.com/apache/hadoop-ozone/pull/85#issuecomment-548416109 Thanks @elek for the review and commit. This is an au

[GitHub] [hadoop-ozone] arp7 commented on issue #88: HDDS-2272. Avoid buffer copying in GrpcReplicationClient

2019-10-31 Thread GitBox
arp7 commented on issue #88: HDDS-2272. Avoid buffer copying in GrpcReplicationClient URL: https://github.com/apache/hadoop-ozone/pull/88#issuecomment-548407657 @bharatviswa504 can you take a look at the `TestOzoneManagerDoubleBufferWithDummyResponse` failure? Does the test need to be fix

[GitHub] [hadoop-ozone] elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341161724 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341160746 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341157131 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341156514 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-31 Thread GitBox
elek commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r341151988 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] elek closed pull request #85: HDDS-2219. Move all the ozone dist scripts/configs to one location

2019-10-31 Thread GitBox
elek closed pull request #85: HDDS-2219. Move all the ozone dist scripts/configs to one location URL: https://github.com/apache/hadoop-ozone/pull/85 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-ozone] elek closed pull request #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka

2019-10-31 Thread GitBox
elek closed pull request #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka URL: https://github.com/apache/hadoop-ozone/pull/47 This is an automated message from the Apa

[GitHub] [hadoop-ozone] elek commented on issue #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka

2019-10-31 Thread GitBox
elek commented on issue #47: HDDS-2208. Propagate System Exceptions from OM transaction apply phase. Contributed by Supratim Deka URL: https://github.com/apache/hadoop-ozone/pull/47#issuecomment-548351399 > Can we have this disable by default via a config flag. This is a debug facility and

[GitHub] [hadoop-ozone] elek commented on issue #80: HDDS-1701. Move dockerbin script to libexec.

2019-10-31 Thread GitBox
elek commented on issue #80: HDDS-1701. Move dockerbin script to libexec. URL: https://github.com/apache/hadoop-ozone/pull/80#issuecomment-548349275 Seems to be working for me even with `acceptance.sh`. Let's try to retest. Th

[GitHub] [hadoop-ozone] elek commented on issue #80: HDDS-1701. Move dockerbin script to libexec.

2019-10-31 Thread GitBox
elek commented on issue #80: HDDS-1701. Move dockerbin script to libexec. URL: https://github.com/apache/hadoop-ozone/pull/80#issuecomment-548349316 /retest This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] elek closed pull request #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone

2019-10-31 Thread GitBox
elek closed pull request #74: HDDS-2348.Remove log4j properties for package org.apache.hadoop.ozone URL: https://github.com/apache/hadoop-ozone/pull/74 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] adoroszlai commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE

2019-10-31 Thread GitBox
adoroszlai commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81#issuecomment-548309510 Hi @fapifta, it seems secure acceptance tests are failing after this change. Some examples: https://github.co

[GitHub] [hadoop-ozone] mukul1987 commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-10-30 Thread GitBox
mukul1987 commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548239263 Thanks for working on this @ChenSammi, I cannot understand the changes, How does moving the createIfNeccessary function fixes the issue ?

[GitHub] [hadoop-ozone] bshashikant commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads

2019-10-30 Thread GitBox
bshashikant commented on issue #82: HDDS-2359. Seeking randomly in a key with more than 2 blocks of data leads to inconsistent reads URL: https://github.com/apache/hadoop-ozone/pull/82#issuecomment-548236013 Thanks @lokeshj1703 for having a look. The test failure in KeyInputStream is happe

[GitHub] [hadoop-ozone] swagle commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-10-30 Thread GitBox
swagle commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548214402 +1 LGTM. This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-30 Thread GitBox
dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#discussion_r340954388 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OM

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-30 Thread GitBox
dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#discussion_r340954497 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OM

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB.

2019-10-30 Thread GitBox
dineshchitlangia commented on a change in pull request #51: HDDS-2311. Fix logic of RetryPolicy in OzoneClientSideTranslatorPB. URL: https://github.com/apache/hadoop-ozone/pull/51#discussion_r340954007 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OM

[GitHub] [hadoop-ozone] ChenSammi commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-10-30 Thread GitBox
ChenSammi commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548197807 Thanks @swagle for the review. A new patch is submitted to address the issues. -

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #11: HDDS-2291. Acceptance tests for OM HA.

2019-10-30 Thread GitBox
hanishakoneru commented on issue #11: HDDS-2291. Acceptance tests for OM HA. URL: https://github.com/apache/hadoop-ozone/pull/11#issuecomment-548181506 /retest This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #104: HDDS-2381. In ExcludeList, add if not exist only.

2019-10-30 Thread GitBox
dineshchitlangia merged pull request #104: HDDS-2381. In ExcludeList, add if not exist only. URL: https://github.com/apache/hadoop-ozone/pull/104 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #106: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone repository

2019-10-30 Thread GitBox
dineshchitlangia merged pull request #106: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone repository URL: https://github.com/apache/hadoop-ozone/pull/106 This is an automated message from the Apache Git S

[GitHub] [hadoop-ozone] anuengineer commented on issue #108: HDDS-1987. Fix listStatus API

2019-10-30 Thread GitBox
anuengineer commented on issue #108: HDDS-1987. Fix listStatus API URL: https://github.com/apache/hadoop-ozone/pull/108#issuecomment-548105219 1. First of all, this is complicated code. But not your fault, what you need to do at this level is complicated. 2. I agree that is one way of

[GitHub] [hadoop-ozone] smengcl opened a new pull request #108: HDDS-1987. Fix listStatus API

2019-10-30 Thread GitBox
smengcl opened a new pull request #108: HDDS-1987. Fix listStatus API URL: https://github.com/apache/hadoop-ozone/pull/108 ## What changes were proposed in this pull request? Fix listStatus API in HA code path. In HA, we have an in-memory cache, where we put the result to in-me

  1   2   3   4   5   6   7   8   9   >