bharatviswa504 commented on a change in pull request #102: HDDS-2380. Use the
Table.isExist() API instead of get() API while checking for presence of key.
URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r341279366
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
##########
@@ -60,15 +60,15 @@ public static OMDirectoryResult verifyFilesInPath(
String dbDirKeyName = omMetadataManager.getOzoneDirKey(volumeName,
bucketName, pathName);
- if (omMetadataManager.getKeyTable().get(dbKeyName) != null) {
+ if (omMetadataManager.getKeyTable().isExist(dbKeyName)) {
Review comment:
yes, thanks @anuengineer for flagging it. Yes in true case if we get value
from block cache we can use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
