Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-15 Thread Viktor Szakáts
Hi Pritpal, I agree with whole concept. > Let us do it right, right now. Only pointers, > no numeric handles at all. Basically, if we have > to use existing code too, we will be changing the > function calls and there stays the whole effort. > > So, it should be like: > #define wapi_par_HWND( n

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-15 Thread Viktor Szakáts
Yes, and sorry, I've answered before noticing this new message of yours. This seems right and even better than my suggestion. Brgds, Viktor On Sun, Feb 15, 2009 at 1:32 AM, Pritpal Bedi wrote: > > Hi > > And this sets everything right, please review: > > #define wapi_par_WNDPROC( n )( ( WN

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-15 Thread Viktor Szakáts
Hi Pritpal, Try with this version: --- #define wapi_par_WNDPROC( n )( ( WNDPROC) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : ( HB_PTRDIFF ) hb_parptr( n ) ) ) #define wapi_par_WPARAM( n ) ( ( WPARAM ) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : ( HB_PTRDIFF ) hb_parptr(

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Pritpal Bedi
Hi And this sets everything right, please review: #define wapi_par_WNDPROC( n )( ( WNDPROC) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : ( HB_PTRDIFF ) hb_parptr( n ) ) ) #define wapi_par_WPARAM( n ) ( ( WPARAM ) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : ( HB_PTRDI

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Pritpal Bedi
Hi Viktor I did changed hbwapi.h as #define wapi_par_WNDPROC( n )( ( WNDPROC) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : hb_parptr( n ) ) ) #define wapi_par_WPARAM( n ) ( ( WPARAM ) ( ISNUM( n ) ? ( HB_PTRDIFF ) hb_parnint( n ) : hb_parptr( n ) ) ) #define wapi_par_

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Pritpal Bedi
Hi Viktor I agree with whole concept. Let us do it right, right now. Only pointers, no numeric handles at all. Basically, if we have to use existing code too, we will be changing the function calls and there stays the whole effort. So, it should be like: #define wapi_par_HWND( n ) ( ( HWND )

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Viktor Szakáts
Hi Pritpal, > > > I agree your implementation is valid, but then it > holds good for new PRG code only. > > If we return pointers and in the next call we sent it back to > another function, then it has to be retried as wapi_par_POINTER()? > Or I am missing something. Yes, it should be retr

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Pritpal Bedi
Viktor < --- wapi_commctrl.c (now) #include #include #include "hbapi.h" #include "hbwapi.h" --- Please don't explicitly #include , it's not necessary, as it's automatically pulled in by hbapi.h by #defining HB_OS_WIN_USED. This is the clean way (notice that commctrl.h is moved after Harbo

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Viktor Szakáts
Hi Pritpal, Ops, sorry I forgot one important issue, could you please use ANSI C comments only? This rule wasn't lifted from hbwin, so we should stick to it to be ANSI C compliant. --- wapi_commctrl.c (now) //--// //

Re: [Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread Viktor Szakáts
Hi Pritpal, --- wapi_commctrl.c (now) #include #include #include "hbapi.h" #include "hbwapi.h" --- Please don't explicitly #include , it's not necessary, as it's automatically pulled in by hbapi.h by #defining HB_OS_WIN_USED. This is the clean way (notice that commctrl.h is moved after Harbour

[Harbour] SF.net SVN: harbour-project:[10273] trunk/harbour

2009-02-14 Thread vouchcac
Revision: 10273 http://harbour-project.svn.sourceforge.net/harbour-project/?rev=10273&view=rev Author: vouchcac Date: 2009-02-14 21:46:19 + (Sat, 14 Feb 2009) Log Message: --- 2009-02-14 13:32 UTC-0800 Pritpal Bedi (prit...@vouchcac.com) + harbour/contrib/hbwin/wapi_