Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Willy Tarreau
On Tue, Aug 06, 2024 at 08:35:21AM +0200, ??? wrote: > I'll provide better script. It is not actual patching, but detection (which > looks like a patching) Yes I know, I'm used to that as well. Our other scripts do that, they provide a patch and that's used to detect in the end. But that'

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Илья Шипицин
I'll provide better script. It is not actual patching, but detection (which looks like a patching) Thanks! On Tue, Aug 6, 2024, 08:25 Willy Tarreau wrote: > On Tue, Aug 06, 2024 at 05:16:11AM +0200, Willy Tarreau wrote: > > > diff --git a/src/fcgi-app.c b/src/fcgi-app.c > > > index b3a9b7c59..9

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Willy Tarreau
On Tue, Aug 06, 2024 at 05:16:11AM +0200, Willy Tarreau wrote: > > diff --git a/src/fcgi-app.c b/src/fcgi-app.c > > index b3a9b7c59..98077b959 100644 > > --- a/src/fcgi-app.c > > +++ b/src/fcgi-app.c > > @@ -606,6 +606,8 @@ static int proxy_parse_use_fcgi_app(char **args, int > > section, struct p

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Willy Tarreau
nd : > > > >> On Mon, Aug 05, 2024 at 08:01:39PM +0200, ??? wrote: > >> > Subject: Re: [PATCH] src/fcgi-app.c: handle strdup failure > >> > ??, 5 ???. 2024 ?. ? 19:56, William Lallemand : > >> > > >> > > On Mon, Aug 05, 2024

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Илья Шипицин
updated patch attached (I preferred that instead of sending with "git send-email") пн, 5 авг. 2024 г. в 20:10, Илья Шипицин : > > > пн, 5 авг. 2024 г. в 20:09, William Lallemand : > >> On Mon, Aug 05, 2024 at 08:01:39PM +0200, Илья Шипицин wrote: >> > Subjec

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Илья Шипицин
пн, 5 авг. 2024 г. в 20:09, William Lallemand : > On Mon, Aug 05, 2024 at 08:01:39PM +0200, Илья Шипицин wrote: > > Subject: Re: [PATCH] src/fcgi-app.c: handle strdup failure > > пн, 5 авг. 2024 г. в 19:56, William Lallemand : > > > > > On Mon, Aug 05, 2024 at 07

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread William Lallemand
On Mon, Aug 05, 2024 at 08:01:39PM +0200, Илья Шипицин wrote: > Subject: Re: [PATCH] src/fcgi-app.c: handle strdup failure > пн, 5 авг. 2024 г. в 19:56, William Lallemand : > > > On Mon, Aug 05, 2024 at 07:17:48PM +0200, Ilia Shipitsin wrote: > > > Subject: [PATCH] src/f

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread Илья Шипицин
пн, 5 авг. 2024 г. в 19:56, William Lallemand : > On Mon, Aug 05, 2024 at 07:17:48PM +0200, Ilia Shipitsin wrote: > > Subject: [PATCH] src/fcgi-app.c: handle strdup failure > > found by coccinelle > > Please add clearer commit messages in your patches, you tend to minimize > them, thanks ! :-) >

Re: [PATCH] src/fcgi-app.c: handle strdup failure

2024-08-05 Thread William Lallemand
On Mon, Aug 05, 2024 at 07:17:48PM +0200, Ilia Shipitsin wrote: > Subject: [PATCH] src/fcgi-app.c: handle strdup failure > found by coccinelle Please add clearer commit messages in your patches, you tend to minimize them, thanks ! :-) > --- > src/fcgi-app.c | 5 - > 1 file changed, 4 insert