I'll provide better script. It is not actual patching, but detection (which looks like a patching)
Thanks! On Tue, Aug 6, 2024, 08:25 Willy Tarreau <w...@1wt.eu> wrote: > On Tue, Aug 06, 2024 at 05:16:11AM +0200, Willy Tarreau wrote: > > > diff --git a/src/fcgi-app.c b/src/fcgi-app.c > > > index b3a9b7c59..98077b959 100644 > > > --- a/src/fcgi-app.c > > > +++ b/src/fcgi-app.c > > > @@ -606,6 +606,8 @@ static int proxy_parse_use_fcgi_app(char **args, > int section, struct proxy *curp > > > if (!fcgi_conf) > > > goto err; > > > fcgi_conf->name = strdup(args[1]); > > > + if (!fcgi_conf->name) > > > + goto err; > > > LIST_INIT(&fcgi_conf->param_rules); > > > LIST_INIT(&fcgi_conf->hdr_rules); > > > > Looks good to me, thanks! I think we can also commit your cocci script > > as dev/coccinelle/strdup.cocci. We'll also mark the fix as BUG/MINOR. > > Now merged as two distinct commits, one for the script and one for the fix. > Thank you Ilya! > willy >
