Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Илья Шипицин
yep, I forgot that json requires a comma (that workflow is scheduled, I overlooked on commit). I'll send fix soon (also, we agreed with haproxyFred upon several things, I split changes into several commits in purpose) сб, 24 авг. 2024 г. в 19:22, Willy Tarreau : > On Sat, Aug 24, 2024 at 07:13

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Willy Tarreau
On Sat, Aug 24, 2024 at 07:13:09PM +0200, Willy Tarreau wrote: > On Sat, Aug 24, 2024 at 07:02:30PM +0200, ??? wrote: > > the reason of adding ngtcp2 is > > > > "let's add and see how it goes". > > > > and that is what we agreed in GH issue :) > > That's fine by me, thank you! Apparent

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Willy Tarreau
On Sat, Aug 24, 2024 at 07:02:30PM +0200, ??? wrote: > the reason of adding ngtcp2 is > > "let's add and see how it goes". > > and that is what we agreed in GH issue :) That's fine by me, thank you! Willy

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Илья Шипицин
the reason of adding ngtcp2 is "let's add and see how it goes". and that is what we agreed in GH issue :) сб, 24 авг. 2024 г. в 18:45, Willy Tarreau : > On Sat, Aug 24, 2024 at 06:15:59PM +0200, ??? wrote: > > it is pretty much about it. > > short commit message "CI: QUIC Interop AWS-L

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Willy Tarreau
On Sat, Aug 24, 2024 at 06:15:59PM +0200, ??? wrote: > it is pretty much about it. > short commit message "CI: QUIC Interop AWS-LC: enable ngtcp2 client" > describes what is done, GH issue is optional. But it does not explain why (or what the purpose is). As I often say it, commit message

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Илья Шипицин
it is pretty much about it. short commit message "CI: QUIC Interop AWS-LC: enable ngtcp2 client" describes what is done, GH issue is optional. сб, 24 авг. 2024 г. в 17:17, Willy Tarreau : > Hi Ilya, > > On Sat, Aug 24, 2024 at 03:55:45PM +0200, Ilya Shipitsin wrote: > > GH issue: https://github.c

Re: [PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Willy Tarreau
Hi Ilya, On Sat, Aug 24, 2024 at 03:55:45PM +0200, Ilya Shipitsin wrote: > GH issue: https://github.com/haproxy/haproxy/issues/2688 While it's fine to put references to GH issues to ease tracking, please always leave a bit of information in the commit message about what the intent of the patch is

[PATCH 3/3] CI: QUIC Interop AWS-LC: enable ngtcp2 client

2024-08-24 Thread Ilya Shipitsin
GH issue: https://github.com/haproxy/haproxy/issues/2688 --- .github/workflows/quic-interop-aws-lc.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/quic-interop-aws-lc.yml b/.github/workflows/quic-interop-aws-lc.yml index 171ec815d..8e3dd9b6c 100644 ---