Re: HAProxy returning 502 with SH--

2024-08-23 Thread BJ Taylor
I will make the suggested changes and try again. Here are the failure logs for the last run. Queues are 0, current connections are not all that high. Aug 22 01:12:12 haproxy[87118]: > {"host":"testserver","ident":"haproxy","pid":87118,"timestamp":"22/Aug/2024:01:12:12 > -0600","haproxy":{"connecti

Re: HAProxy returning 502 with SH--

2024-08-23 Thread Lukas Tribus
On Fri, 23 Aug 2024 at 18:55, BJ Taylor wrote: > > We are trying to deploy HAProxy into our environment. We have a script that > does some 600k api calls during approximately 24 hours. How many concurrent connections / transactions though? > During that time, when haproxy is in place, there ar

HAProxy returning 502 with SH--

2024-08-23 Thread BJ Taylor
We are trying to deploy HAProxy into our environment. We have a script that does some 600k api calls during approximately 24 hours. During that time, when haproxy is in place, there are a handful (8-12) of responses that come back as 502 with SH--. We've tested this against Ubuntu's default 2.8 ver

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Matthieu Baerts
On 23/08/2024 17:20, Willy Tarreau wrote: > On Fri, Aug 23, 2024 at 05:11:11PM +0200, Matthieu Baerts wrote: (...) >> Maybe a new socket option would be better if the idea is only to >> silently drop connections? :) > > Yes, probably. Right now it's done directly in the action itself > (tcp_exec

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Willy Tarreau
On Fri, Aug 23, 2024 at 05:11:11PM +0200, Matthieu Baerts wrote: > >>> With that said, from an implementation perspective, it would seem right > >>> to make sure that most TCP tunables also work with MPTCP. > >> > >> That's what we tried to do. All "common" ones are supported, but it is > >> not al

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Matthieu Baerts
On 23/08/2024 16:42, Willy Tarreau wrote: > On Fri, Aug 23, 2024 at 04:13:16PM +0200, Matthieu Baerts wrote: (...) >>> I'll comment on each patch separately, >> >> Thank you, please take your time! > > That's what I'm doing but I really want to make sure we won't discover > last-minute show-stop

Re: [PATCH 2/2] BUG/MINOR: fix warning when setting MSS with MPTCP

2024-08-23 Thread Willy Tarreau
On Fri, Aug 23, 2024 at 04:50:33PM +0200, Willy Tarreau wrote: > > @@ -494,6 +498,30 @@ static void sock_inet_prepare() > > #endif > > close(fd); > > } > > + > > +#ifdef __linux__ > > Here I think a short comment is deserved to explain why __linux__, because > it's the same choice

Re: [PATCH 2/2] BUG/MINOR: fix warning when setting MSS with MPTCP

2024-08-23 Thread Willy Tarreau
On Fri, Aug 23, 2024 at 03:34:10PM +0200, Aperence wrote: > Currently, the TCP_MAXSEG socket option doesn't seem to be supported > with MPTCP. This results in a warning when trying to set the MSS of > sockets in proto_tcp:tcp_bind_listener. > > This can be resolved by adding two new variables: > s

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Willy Tarreau
Hi Matthieu, On Fri, Aug 23, 2024 at 04:13:16PM +0200, Matthieu Baerts wrote: > Hi Willy, > > Thank you for your quick reply! You're welcome! > > I'll comment on each patch separately, > > Thank you, please take your time! That's what I'm doing but I really want to make sure we won't discover

Re: [PATCH 1/2] FEATURE: add MPTCP per address support

2024-08-23 Thread Willy Tarreau
On Fri, Aug 23, 2024 at 03:34:09PM +0200, Aperence wrote: (...) > MPTCP is both supported for the frontend and backend sides. Great! > Also added an example of configuration using mptcp along with a backend > allowing to experiment with it. Thanks for thinking about testing ;-) > Note that this

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Matthieu Baerts
Hi Willy, Thank you for your quick reply! On 23/08/2024 15:58, Willy Tarreau wrote: > On Fri, Aug 23, 2024 at 03:34:08PM +0200, Aperence wrote: (...) > I'll comment on each patch separately, Thank you, please take your time! > though I'll respond to the > question below: > >> - Patch 2: >>

Re: [PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Willy Tarreau
Hello! On Fri, Aug 23, 2024 at 03:34:08PM +0200, Aperence wrote: > Multipath TCP (MPTCP), standardized in RFC8684 [1], is a TCP extension > that enables a TCP connection to use different paths. > > Multipath TCP has been used for several use cases. On smartphones, MPTCP > enables seamless handove

[PATCH 2/2] BUG/MINOR: fix warning when setting MSS with MPTCP

2024-08-23 Thread Aperence
Currently, the TCP_MAXSEG socket option doesn't seem to be supported with MPTCP. This results in a warning when trying to set the MSS of sockets in proto_tcp:tcp_bind_listener. This can be resolved by adding two new variables: sock_inet(6)_mptcp_maxseg_default that will hold the default value of t

[PATCH 1/2] FEATURE: add MPTCP per address support

2024-08-23 Thread Aperence
Multipath TCP (MPTCP), standardized in RFC8684 [1], is a TCP extension that enables a TCP connection to use different paths. Multipath TCP has been used for several use cases. On smartphones, MPTCP enables seamless handovers between cellular and Wi-Fi networks while preserving established connecti

[PATCH 0/2] Add MPTCP to haproxy

2024-08-23 Thread Aperence
Multipath TCP (MPTCP), standardized in RFC8684 [1], is a TCP extension that enables a TCP connection to use different paths. Multipath TCP has been used for several use cases. On smartphones, MPTCP enables seamless handovers between cellular and Wi-Fi networks while preserving established connecti