On Fri, Aug 23, 2024 at 04:50:33PM +0200, Willy Tarreau wrote: > > @@ -494,6 +498,30 @@ static void sock_inet_prepare() > > #endif > > close(fd); > > } > > + > > +#ifdef __linux__ > > Here I think a short comment is deserved to explain why __linux__, because > it's the same choice that was made in proto_tcp.c. > > Or better, you could probably do that in compat.h: > > #ifdef __linux__ > # define HA_HAVE_MPTCP 1 > # ifndef IPPROTO_TCP > # define IPPROTO_TCP ... > # endif > #endif > > and use #ifdef HA_HAVE_MPTCP here and around the variables above. That > would make it quite clear about what we're really checking for here.
Oh and BTW adding a link in a comment to the issue that Matthieu just opened regarding TCP_MSS support would help the future us rediscovering that code decide whether to remerge that with TCP or not once fully supported everywhere. Willy
