Re: [PATCH] getifaddrs wrapper

A bug causing broadcast-addr and other fields AFTER the flags field in 'struct getifaddrs' to be accessed incorrectly has been fixed. On 2 July 2015 at 17:53, Ludovic Courtès wrote: > Rohan Prinja skribis: > >> PTAL, tests to follow soon. > > It’s looking good now, thanks! > > Could you send the

[PATCH 1/7] gnu: Add libfm-extra.

* gnu/packages/lxde.scm (libfm-extra): New variable. --- gnu/packages/lxde.scm | 26 ++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index cf837f5..29e1f36 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -17

[PATCH 5/7] gnu: Add lxterminal.

* gnu/packages/lxde.scm (lxterminal): New variable. --- gnu/packages/lxde.scm | 25 + 1 file changed, 25 insertions(+) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 47d6627..a8fb10a 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -89,6

[PATCH 2/7] gnu: Add menu-cache.

* gnu/packages/lxde.scm (menu-cache): New variable. --- gnu/packages/lxde.scm | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 29e1f36..1d3a9ea 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lx

[PATCH 6/7] gnu: Add lxtask.

* gnu/packages/lxde.scm (lxtask): New variable. --- gnu/packages/lxde.scm | 24 1 file changed, 24 insertions(+) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index a8fb10a..a28eb3f 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -89,6 +89,

[PATCH 3/7] gnu: Add libfm.

* gnu/packages/lxde.scm (libfm): New variable. (libfm-extra): Inherit from it. --- gnu/packages/lxde.scm | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index 1d3a9ea..bd078ff 100644 --- a/gnu/p

[PATCH 7/7] gnu: Add lxrandr.

* gnu/packages/lxde.scm (lxrandr): New variable. --- gnu/packages/lxde.scm | 26 ++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index a28eb3f..ef2d60c 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -89,6 +

[PATCH 4/7] gnu: Add pcmanfm.

* gnu/packages/lxde.scm (pcmanfm): New variable. --- gnu/packages/lxde.scm | 28 1 file changed, 28 insertions(+) diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm index bd078ff..47d6627 100644 --- a/gnu/packages/lxde.scm +++ b/gnu/packages/lxde.scm @@ -22,6

[PATCH 0/7] Add LXDE packages.

Here is a first batch of LXDE packages. More to come soon ;) You will see a little mess in the libfm patch which is a consequence of a bootstrap problem between menu-cache and libfm which is describe like this in the README file of menu-cache. Since version 0.7.0 the Libmenu-cache requires

Re: Of sounds and locales

matias_jose_s...@autoproduzioni.net (2015-07-15 23:08 +0300) wrote: > Humanists and Magicians, > i'm very glad to began this journey around BuildYourWorld dimension! > In particular i've successfully generated the GuixSD station at > Libreboot X60, > and it runs like a free deer over the woods! >

Re: [PATCH 02/11] gnu: Add oslotest.

Hi, I've not test it but I have some stylistic remarks :). Most of them apply to other parts of your patch and to the other patches. Cyril Roelandt writes: > +(define-public python-mox3 > + (package > + (name "python-mox3") ^ It should be indent under the first 'a'. > + (uri (strin

[PATCH] gnu packages: Clean up synopses and descriptions.

Please pay attention to the commit message. Is it acceptable? >From ccd85cd8fc1b4c71a1e1fe02ad06f0a5413517e3 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Thu, 16 Jul 2015 12:14:13 +0300 Subject: [PATCH] gnu packages: Clean up synopses and descriptions. MIME-Version: 1.0 Content-Type: text/plai

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Alex Kost writes: > Please pay attention to the commit message. Is it acceptable? :) For the typos and polishing fixes, I would prefer that the commits were done in a module related way. So IMO It would be better to have one commit per-file. Concerning the "•", I think no decision has been ma

Re: [PATCH] gnu: Add exempi and eog.

Oops! I forgot that I could remove the #:phases section and autotools native-inputs in exempi since we're using the tarball. Fixed in the attached patch. On Wed, Jul 15, 2015 at 11:28 PM, David Hashe wrote: > Thanks to everyone for the reviews! > > I got boost working and changed everything that

Re: [PATCH] getifaddrs wrapper

Added a convenience macro to make the filtering out of unneeded interfaces cleaner. On 16 July 2015 at 14:00, Rohan Prinja wrote: > A bug causing broadcast-addr and other fields AFTER the flags field in > 'struct getifaddrs' to be accessed incorrectly has been fixed. > > On 2 July 2015 at 17:53,

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

On Thu, 16 Jul 2015 14:17:22 +0300 Alex Kost wrote: > --- a/gnu/packages/base.scm > +++ b/gnu/packages/base.scm > @@ -58,7 +58,7 @@ > (sha256 > (base32 > "0ssi1wpaf7plaswqqjwigppsg5fyh99vdlb9kzl7c9lng89ndq1i" > (build-system gnu-build-system) > - (synopsis "Hello,

Re: [PATCH] getifaddrs wrapper

Rohan Prinja skribis: > Added a convenience macro to make the filtering out of unneeded > interfaces cleaner. >> On 2 July 2015 at 17:53, Ludovic Courtès wrote: [...] >>> Could you send the updated patch against master, that includes a simple >>> test in tests/syscalls.scm that makes sure tha

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Mathieu Lirzin skribis: > For the typos and polishing fixes, I would prefer that the commits were > done in a module related way. So IMO It would be better to have one > commit per-file. I think one per file would be overkill (and not really helpful review-wise.) One per fix would be nice thoug

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Eric Bavier (2015-07-16 12:40 +0300) wrote: > On Thu, 16 Jul 2015 14:17:22 +0300 > Alex Kost wrote: > >> --- a/gnu/packages/base.scm >> +++ b/gnu/packages/base.scm >> @@ -58,7 +58,7 @@ >> (sha256 >> (base32 >> "0ssi1wpaf7plaswqqjwigppsg5fyh99vdlb9kzl7c9lng89ndq1i" >

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Mathieu Lirzin (2015-07-16 14:52 +0300) wrote: > For the typos and polishing fixes, I would prefer that the commits were > done in a module related way. So IMO It would be better to have one > commit per-file. IMHO it is better to have a single commit fixing 20 typos than 20 commits fixing one ty

Re: [PATCH] gnu: Add lxappearance.

Mathieu Lirzin writes: > Alex Kost writes: > >> I think it should be: >>> +"mirror://sourceforge/project/lxde/LXAppearance/" >> >> guix download >> "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz" >> >> gives some html file. Otherwise it loo

Re: [PATCH] gnu: Add lxappearance.

Mark H Weaver (2015-07-16 19:41 +0300) wrote: > Mathieu Lirzin writes: > >> Alex Kost writes: >> >>> I think it should be: +"mirror://sourceforge/project/lxde/LXAppearance/" >>> >>> guix download >>> "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Alex Kost skribis: > Eric Bavier (2015-07-16 12:40 +0300) wrote: > >> On Thu, 16 Jul 2015 14:17:22 +0300 >> Alex Kost wrote: >> >>> --- a/gnu/packages/base.scm >>> +++ b/gnu/packages/base.scm >>> @@ -58,7 +58,7 @@ >>> (sha256 >>> (base32 >>> "0ssi1wpaf7plaswqqjwigppsg5

Re: [PATCH] gnu: Add lxappearance.

Alex Kost writes: > So Mathieu's LXDE patches can't be checked right now :-( Thanks for looking into it. There is a missing '/' too. I will send a fix when sourceforge will work again. Sorry for the mistake, I will be more careful next time. -- Mathieu Lirzin

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

Alex Kost writes: > Mathieu Lirzin (2015-07-16 14:52 +0300) wrote: > > IMHO it is better to have a single commit fixing 20 typos than 20 > commits fixing one typo. Your are right. > How can we understand when a decision is made? I had an impression > (perhaps wrong) that people are not going t

Re: [PATCH] gnu packages: Clean up synopses and descriptions.

l...@gnu.org (Ludovic Courtès) writes: > What are your concerns and what would you prefer? (I was left with the > impression that there was a rough consensus in the other thread, but > surely there’s a bias.) > > In Emacs it’s quite easily typed (C-x 8 RET etc.), and at worst people > can copy/pa

Re: Of sounds and locales

matias_jose_s...@autoproduzioni.net skribis: > Humanists and Magicians, > i'm very glad to began this journey around BuildYourWorld dimension! > In particular i've successfully generated the GuixSD station at > Libreboot X60, > and it runs like a free deer over the woods! Thanks for your joining

[PATCH] Add Non Sequencer.

>From 57265b8363add56ea0ea2f35310c39db7e2b14ed Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Fri, 17 Jul 2015 08:46:44 +0200 Subject: [PATCH 1/2] gnu: Add NTK. * gnu/packages/fltk.scm (ntk): New variable. --- gnu/packages/fltk.scm | 53 ++- 1