Re: New “ungrafting” branch

2021-01-21 Thread Leo Famulari
On Thu, Jan 21, 2021 at 12:15:28PM +0100, Ludovic Courtès wrote: > Apologies for not contributing so far, this month is busy for me. I > think the slow feedback loop with ci.guix is one of the main reasons > people don’t contribute much. Perhaps the whole process is also unclear > to people who’r

Re: New “ungrafting” branch

2021-01-21 Thread Ludovic Courtès
Hi, Leo Famulari skribis: > On Fri, Jan 15, 2021 at 12:57:50AM -0500, Mark H Weaver wrote: >> Ludovic Courtès writes: >> >> > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch >> > that does nothing but ungraft things. >> > >>

Re: New “ungrafting” branch

2021-01-15 Thread Leo Famulari
On Fri, Jan 15, 2021 at 12:57:50AM -0500, Mark H Weaver wrote: > Ludovic Courtès writes: > > > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch > > that does nothing but ungraft things. > > > > The rationale is that grafts incur additional overh

Re: New “ungrafting” branch

2021-01-14 Thread Mark H Weaver
Hi Ludovic, Ludovic Courtès writes: > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch > that does nothing but ungraft things. > > The rationale is that grafts incur additional overhead when installing > things (the time to create those grafts), so it’s good t

Re: New “ungrafting” branch

2020-12-18 Thread Andreas Enge
Hello, Am Mon, Dec 14, 2020 at 04:00:36PM -0500 schrieb Leo Famulari: > I agree, it's not a violation of the functional packaging model in a > strict sense. if I understand correctly, it remains confusing in a non-strict sense: grafting is functional, but it is not the same function. Precisely, t

Re: New “ungrafting” branch

2020-12-17 Thread zimoun
Hi Mark and Leo, Thanks for the explanations. All is clear. All the best, simon

Re: New “ungrafting” branch

2020-12-14 Thread Leo Famulari
On Mon, Dec 14, 2020 at 03:03:16PM -0500, Mark H Weaver wrote: > So, it's still a mathematical function (assuming all packages build > deterministically), but not necessarily the same function as if normal > upgrades had been done instead of grafts. That's the main issue with > grafts that I'm awa

Re: New “ungrafting” branch

2020-12-14 Thread Mark H Weaver
Hi Leo, Leo Famulari writes: > When we added the recursive grafting feature, we intended to use it to > deploy urgent security updates quickly, but we also intended to > "ungraft" quickly, maybe in a week or two. We never planned to keep > packages grafted for several months as we do now — graft

Re: New “ungrafting” branch

2020-12-14 Thread Leo Famulari
On Mon, Dec 14, 2020 at 11:32:05AM +0100, zimoun wrote: > But if grafts is here, it is because of something. Therefore, I do not > understand what it does mean “ungraft”. Avoid the grafting mechanism > when it is possible? Grafts are used to "hack" the package dependency graph. We try to make so

Re: New “ungrafting” branch

2020-12-14 Thread zimoun
Hi Leo, On Tue, 08 Dec 2020 at 13:20, Leo Famulari wrote: > On Tue, Dec 08, 2020 at 03:13:40PM +0100, zimoun wrote: >> I have missed the discussion on IRC and I do not understand the >> rationale. What's the point of "ungrafting"? > > Grafts cause profile operations like `guix install` and `guix

Re: New “ungrafting” branch

2020-12-14 Thread Ludovic Courtès
Hi, Christopher Baines skribis: > Ludovic Courtès writes: > >> Following discussions on IRC, I’ve created a new ‘ungrafting’ branch >> that does nothing but ungraft things. >> >> The rationale is that grafts incur additional overhead when installing >> thi

Re: New “ungrafting” branch

2020-12-10 Thread Maxim Cournoyer
Hello Ludo, Ludovic Courtès writes: > Hi Guix! > > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch > that does nothing but ungraft things. > > The rationale is that grafts incur additional overhead when installing > things (the time to create those gra

Re: New “ungrafting” branch

2020-12-08 Thread Christopher Baines
Ludovic Courtès writes: > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch > that does nothing but ungraft things. > > The rationale is that grafts incur additional overhead when installing > things (the time to create those grafts), so it’s good to clean them

Re: New “ungrafting” branch

2020-12-08 Thread Leo Famulari
On Tue, Dec 08, 2020 at 03:13:40PM +0100, zimoun wrote: > I have missed the discussion on IRC and I do not understand the > rationale. What's the point of "ungrafting"? Grafts cause profile operations like `guix install` and `guix environment` to be slower than without grafts.

Re: New “ungrafting” branch

2020-12-08 Thread Andreas Enge
Hello, On Tue, Dec 08, 2020 at 03:13:40PM +0100, zimoun wrote: > I have missed the discussion on IRC and I do not understand the > rationale. What's the point of "ungrafting"? I suppose it is just a branch with all the patches that are grafted applied, so that it is not necessary to graft them a

Re: New “ungrafting” branch

2020-12-08 Thread zimoun
Hi Ludo, On Tue, 8 Dec 2020 at 12:29, Ludovic Courtès wrote: > Following discussions on IRC, I’ve created a new ‘ungrafting’ branch > that does nothing but ungraft things. > > The rationale is that grafts incur additional overhead when installing > things (the time to create th

New “ungrafting” branch

2020-12-08 Thread Ludovic Courtès
Hi Guix! Following discussions on IRC, I’ve created a new ‘ungrafting’ branch that does nothing but ungraft things. The rationale is that grafts incur additional overhead when installing things (the time to create those grafts), so it’s good to clean them up once in a while. Ungrafting in a