Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-10-04 Thread Vincent Legoll
Hello, >> The "changelog entries are like an undo list" is a WTF, to me this is what >> `patch -R` is for... > > Not quite, because the change log shows the language-level view of the > changes, I don't understand "language-level view of the changes" > It makes it easy to answer questions such a

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-10-03 Thread Ludovic Courtès
Hi, Vincent Legoll skribis: > On Wed, Sep 28, 2016 at 11:11 PM, Ludovic Courtès wrote: >> > > I read this and still am on the opposite side. > > The "changelog entries are like an undo list" is a WTF, to me this is what > `

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-10-03 Thread Vincent Legoll
Hello, On Wed, Sep 28, 2016 at 11:11 PM, Ludovic Courtès wrote: > I read this and still am on the opposite side. The "changelog entries are like an undo list" is a WTF, to me this is what `patch -R` is for... My take on th

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-28 Thread Ludovic Courtès
Mark H Weaver skribis: > Our conventions for commit logs, which follow the GNU Coding Standards > for Change Logs (see section 6.8 of the GNU Coding Standards), is that > explanations belong in the comments of the code itself, not in the > commit log. If that had been done in the example you giv

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-28 Thread Ludovic Courtès
John Darrington skribis: > I don't object to a having a common style. I just wish that the information > that we put in our messages a) gave the rationale for the change; and b) > didn't > merely repeat information which git show could have told me. The rationale should really go to comments

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-28 Thread Ludovic Courtès
Hi, Vincent Legoll skribis: > Is it just me finding this changelog format usefulness to be > very low ? The change log is just a log of changes, not the place where we explain the why and how—this rather goes to comments. See

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-27 Thread John Darrington
On Tue, Sep 27, 2016 at 08:14:38PM -0400, Mark H Weaver wrote: Our conventions for commit logs, which follow the GNU Coding Standards for Change Logs (see section 6.8 of the GNU Coding Standards), is that explanations belong in the comments of the code itself, not in the c

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-27 Thread Mark H Weaver
John Darrington writes: > On Mon, Sep 26, 2016 at 04:24:10PM +0200, Vincent Legoll wrote: > Hello, > > @David: the following question is nothing against you, I just > took the opportunity to ask, sorry for the thread hijacking. > > On Mon, Sep 26, 2016 at 3:23 PM,

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-27 Thread Tobias Geerinckx-Rice
Hullo, On 26/09/16 18:49, John Darrington wrote: > I vote that we make the reason for a commit to be compulsory. +1, s/commit/non-trivial commit/ I agree that it should be more strongly encouraged, if just to make people aware that it's actually allowed — plenty aren't. If no-one submits a prop

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Leo Famulari
On Mon, Sep 26, 2016 at 08:06:13PM +0200, David Craven wrote: > > I don't object to a having a common style. I just wish that the > > information > > that we put in our messages a) gave the rationale for the change; and b) > > didn't > > merely repeat information which git show could have told

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread David Craven
> Recently, on another project, I came across a line of code which I > was pretty sure was pointless. The guy who wrote that line should have included a comment in that case. The git history isn't a replacement for code commenting. Code needs to be readable without looking at it's history.

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Vincent Legoll
> So is anyone against this change or just my commit message? Would > someone like to suggest a better one? The discussion about changelog style is orthogonal to this patch, LGTM, with your explanation to John's question, we can see why this change is done. Let's not hold this hostage to $OTHER_S

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread David Craven
> I don't object to a having a common style. I just wish that the information > that we put in our messages a) gave the rationale for the change; and b) > didn't > merely repeat information which git show could have told me. So is anyone against this change or just my commit message? Would some

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread John Darrington
On Mon, Sep 26, 2016 at 01:31:09PM -0400, Leo Famulari wrote: On Mon, Sep 26, 2016 at 06:49:34PM +0200, John Darrington wrote: > Our current convention for commit messages is aesthetically pleasing, > but useless. It is redundant to put in the message WHAT has changed. > That

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Leo Famulari
On Mon, Sep 26, 2016 at 06:49:34PM +0200, John Darrington wrote: > Our current convention for commit messages is aesthetically pleasing, > but useless. It is redundant to put in the message WHAT has changed. > That can be easily determined by running "git show". What is much > more usefull is t

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Vincent Legoll
> I entirely agree. I'm not alone :-) > Our current convention for commit messages is aesthetically pleasing, > but useless. It is redundant to put in the message WHAT has changed. > That can be easily determined by running "git show". What is much > more usefull is the reason WHY we changed

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread John Darrington
On Mon, Sep 26, 2016 at 04:24:10PM +0200, Vincent Legoll wrote: Hello, @David: the following question is nothing against you, I just took the opportunity to ask, sorry for the thread hijacking. On Mon, Sep 26, 2016 at 3:23 PM, John Darrington wrote: > Why are we

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Ricardo Wurmus
Vincent Legoll writes: > @David: the following question is nothing against you, I just > took the opportunity to ask, sorry for the thread hijacking. > > On Mon, Sep 26, 2016 at 3:23 PM, John Darrington wrote: >> Why are we removing this? > > Is it just me finding this changelog format usefulnes

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread Vincent Legoll
Hello, @David: the following question is nothing against you, I just took the opportunity to ask, sorry for the thread hijacking. On Mon, Sep 26, 2016 at 3:23 PM, John Darrington wrote: > Why are we removing this? Is it just me finding this changelog format usefulness to be very low ? I've come

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread David Craven
It's for the original beagle bone I think, not the beagle bone black, so it's named wrong at best. I'm using the generic kernel for my bbb. Unless someone has a bb board and wants to test this, it's just code no one is using.

Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread John Darrington
Why are we removing this? On Mon, Sep 26, 2016 at 12:34:45PM +0200, David Craven wrote: * gnu/packages/linux.scm (linux-libre-beagle-bone-black): Remove. --- gnu/packages/linux.scm | 7 --- 1 file changed, 7 deletions(-) diff --git a/gnu/packages/linux.scm b/gn

[PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.

2016-09-26 Thread David Craven
* gnu/packages/linux.scm (linux-libre-beagle-bone-black): Remove. --- gnu/packages/linux.scm | 7 --- 1 file changed, 7 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 243a71c..6f7986d 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -339,13