Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
> That would be a massive refactoring - but can be done eventually. I don't think it would be too hard, most work can be done through applying a regex to the entire project and running the testsuite to find the cases where it didn't work. I did this on the python.scm file... So then I'll leave th

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread Danny Milosavljevic
On Wed, 17 Aug 2016 10:53:23 +0200 David Craven wrote: > Ah, I was thinking more about lgpl2.1+ and the sorts... So is it a > good idea to prefix all licenses in guix licenses itself (as Eric > mentioned), and be done with it? That would be a massive refactoring - but can be done eventually. I

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
> Expat causes a name collision. > > Also nmap, boost, cecill-c, freetype, imlib2, openldap2.0, openssl, ruby, > tcl/tk, vim, x11, zlib. > > Should there be new licenses it's a good guess it will be named like the > package it originated in. > > I would not advise removing the prefix. If anything

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread Danny Milosavljevic
On Wed, 17 Aug 2016 10:02:26 +0200 David Craven wrote: > I wonder who started the #:prefix/#:select thing in the first place. I > don't think that anything from guix licenses is likely to cause a name > collision. Maybe it's best to remove the #:prefix entirely? Expat causes a name collision.

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-17 Thread David Craven
I wonder who started the #:prefix/#:select thing in the first place. I don't think that anything from guix licenses is likely to cause a name collision. Maybe it's best to remove the #:prefix entirely?

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 23:15:07 +0300 Alex Kost wrote: > David Craven (2016-08-16 21:39 +0300) wrote: > > > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > > #:prefix > > license:. > > (orc): Likewise. > > (gstreamer): Likewise. > > (gst-plugins-base): Likewise. >

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread David Craven
> I like this patch. However in general (a question for Guix people): is > there a reason to use #:select for licenses? Or would it be better to > use #:prefix everywhere? If the latter (my preference), I think it > would be good to make this "#:select"→"#:prefix" change in a single > patch inst

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > #:prefix > license:. > (orc): Likewise. > (gstreamer): Likewise. > (gst-plugins-base): Likewise. > (gst-plugins-good): Likewise. > (gst-plugins-bad): Likewise. >

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Danny Milosavljevic
LGTM.

[PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread David Craven
* gnu/packages/gstreamer.scm (define-module): Import guix licenses with #:prefix license:. (orc): Likewise. (gstreamer): Likewise. (gst-plugins-base): Likewise. (gst-plugins-good): Likewise. (gst-plugins-bad): Likewise. (gst-plugins-ugly): Likewise. (gst-libav): Likewise. (python-