On Tue, 16 Aug 2016 23:15:07 +0300 Alex Kost <alez...@gmail.com> wrote:
> David Craven (2016-08-16 21:39 +0300) wrote: > > > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > > #:prefix > > license:. > > (orc): Likewise. > > (gstreamer): Likewise. > > (gst-plugins-base): Likewise. > > (gst-plugins-good): Likewise. > > (gst-plugins-bad): Likewise. > > (gst-plugins-ugly): Likewise. > > (gst-libav): Likewise. > > (python-gst): Likewise. > ^^ > Please remove the leading spaces before "(...): Likewise." In fact, I think this is a case where one could simple say something like "Adjust license references". > I like this patch. However in general (a question for Guix people): is > there a reason to use #:select for licenses? Or would it be better to > use #:prefix everywhere? If the latter (my preference), I think it > would be good to make this "#:select"→"#:prefix" change in a single > patch instead of making separate patches for different modules. I don't think it's something that needs to be mandated. If we were to use '#:prefix license:' everywhere, we might as well save the trouble and just rename everything in (guix license) with the prefix. But I don't think this is necessary. There are instances of importing with '#:hide' even, which I think has its place. `~Eric
