Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-31 Thread Ludovic Courtès
Mathieu Lirzin skribis: > Eric Bavier writes: > >>> +doc/guix-%.1: guix/scripts/%.scm $(GOBJECTS) >>> + -$(AM_V_HELP2MAN)case '$?' in \ >>> + *$<*) $(gen_man) --output="$@" "guix `basename "$<" .scm`";; \ >>> + *): ;; \ >>> + esac >> >> The `basename "$<" .scm` could be reduced t

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-29 Thread Mathieu Lirzin
Eric Bavier writes: >> +doc/guix-%.1: guix/scripts/%.scm $(GOBJECTS) >> +-$(AM_V_HELP2MAN)case '$?' in \ >> + *$<*) $(gen_man) --output="$@" "guix `basename "$<" .scm`";; \ >> + *): ;; \ >> +esac > > The `basename "$<" .scm` could be reduced to $* here. > > In my patch I was

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-29 Thread Eric Bavier
On 2016-01-29 10:17, Mathieu Lirzin wrote: Eric Bavier writes: On Thu, 28 Jan 2016 18:00:35 +0100 Mathieu Lirzin wrote: OTOH I must admit that for maintainability reasons I would prefer avoiding complexity in Makefiles as much as possible. This means using Automake's abstract concepts as m

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-29 Thread Mathieu Lirzin
Eric Bavier writes: > On Thu, 28 Jan 2016 18:00:35 +0100 > Mathieu Lirzin wrote: > >> OTOH I must admit that for maintainability reasons I would prefer >> avoiding complexity in Makefiles as much as possible. This means >> using Automake's abstract concepts as much as possible, having a >> simp

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-28 Thread Eric Bavier
On Thu, 28 Jan 2016 18:00:35 +0100 Mathieu Lirzin wrote: > OTOH I must admit that for maintainability reasons I would prefer > avoiding complexity in Makefiles as much as possible. This means > using Automake's abstract concepts as much as possible, having a > simple dependency graph on top of t

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-28 Thread Mathieu Lirzin
Eric Bavier writes: >>> diff --git a/doc.am b/doc.am >>> index f15efcc..b3996d1 100644 >>> --- a/doc.am >>> +++ b/doc.am >>> @@ -106,9 +106,18 @@ doc/guix-daemon.1: nix/nix-daemon/guix-daemon.cc >>> >>> define subcommand-manual-target >>> >>> -doc/guix-$(1).1: guix/scripts/$(1).scm >>> - -LANG

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-28 Thread Eric Bavier
On 2016-01-28 09:44, Mathieu Lirzin wrote: Hi Eric, Eric Bavier writes: Here's my rough first take at this. It uses the status 77 convention to update a sentinel file and selectively run help2man. I realize the silent rule output isn't yet polished. I have pushed the reviewed patches. So

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-28 Thread Mathieu Lirzin
Hi Eric, Eric Bavier writes: > Here's my rough first take at this. It uses the status 77 convention > to update a sentinel file and selectively run help2man. > > I realize the silent rule output isn't yet polished. I have pushed the reviewed patches. So now it is polished. :) > From 038645a3

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-27 Thread Eric Bavier
On Tue, 26 Jan 2016 21:08:36 +0100 Mathieu Lirzin wrote: > l...@gnu.org (Ludovic Courtès) writes: > > > Mathieu Lirzin skribis: > > > >> * configure.ac (BUILD_FROM_GIT): New Automake conditional. > >> * doc.am (SUBCOMMANDS): Delete variable. > >> (dist_man1_MANS): List all subcommands man pages

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-26 Thread Mathieu Lirzin
l...@gnu.org (Ludovic Courtès) writes: > Mathieu Lirzin skribis: > >> * configure.ac (BUILD_FROM_GIT): New Automake conditional. >> * doc.am (SUBCOMMANDS): Delete variable. >> (dist_man1_MANS): List all subcommands man pages. >> (doc/guix.1): Build only if BUILD_FROM_GIT. Depend on 'scripts/guix

Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-26 Thread Ludovic Courtès
Mathieu Lirzin skribis: > This improves compilation speed since scripts are not compiled twice. > When building with ‘make -j4‘ from a clean repository on an Intel > i5-2540M, the time of compilation gets from: > > real 5m7.220s > user 18m49.788s > sys 0m12.964s > > down to: > > real 2m20.82

[PATCH 06/13] build: Generate man pages after compiling guile objects.

2016-01-24 Thread Mathieu Lirzin
This improves compilation speed since scripts are not compiled twice. When building with ‘make -j4‘ from a clean repository on an Intel i5-2540M, the time of compilation gets from: real5m7.220s user18m49.788s sys 0m12.964s down to: real2m20.820s user7m25.992s sys 0m7.464