Mathieu Lirzin <m...@gnu.org> skribis:

> Eric Bavier <ericbav...@openmailbox.org> writes:
>
>>> +doc/guix-%.1: guix/scripts/%.scm $(GOBJECTS)
>>> +   -$(AM_V_HELP2MAN)case '$?' in \
>>> +     *$<*) $(gen_man) --output="$@" "guix `basename "$<" .scm`";; \
>>> +     *)    : ;; \
>>> +   esac
>>
>> The `basename "$<" .scm` could be reduced to $* here.
>>
>> In my patch I was trying to avoid printing the case et al in verbose
>> mode.  This should be fine though; anyone reading the output of a
>> verbose build might not be put off my the sh.
>>
>> The rest LGTM!
>
> pushed in 36629097523b0abd89d1b931293150cb9c1f242d with slight
> modifications.

Thanks to the two of you for the smart hack!

Ludo’.

Reply via email to