Re: [PATCH] gnu: Add sonata

2016-09-12 Thread Thompson, David
On Sun, Sep 11, 2016 at 11:08 AM, Leo Famulari wrote: > On Sun, Sep 11, 2016 at 11:00:37AM +0100, Christopher Baines wrote: >> * gnu/packages/mpd.scm (sonata): New variable. > > Thanks! Pushed as 6c86cef5d36d613be0a62f8f18e276232abf51f0. > > This will make it easier for my houseguests to control t

Re: [PATCH] gnu: Add sonata

2016-09-11 Thread Christopher Baines
On 11/09/16 18:01, Alex Kost wrote: Christopher Baines (2016-09-11 11:00 +0100) wrote: * gnu/packages/mpd.scm (sonata): New variable. --- gnu/packages/mpd.scm | 53 1 file changed, 53 insertions(+) diff --git a/gnu/packages/mpd.scm b/gnu/pa

Re: [PATCH] gnu: Add sonata

2016-09-11 Thread Leo Famulari
On Sun, Sep 11, 2016 at 08:01:19PM +0300, Alex Kost wrote: > Christopher Baines (2016-09-11 11:00 +0100) wrote: > > + #:use-module ((guix build glib-or-gtk-build-system) #:prefix > > glib-or-gtk:) > > This line is not needed. You use it in the #:modules argument in the > package definition, but

Re: [PATCH] gnu: Add sonata

2016-09-11 Thread Alex Kost
Christopher Baines (2016-09-11 11:00 +0100) wrote: > * gnu/packages/mpd.scm (sonata): New variable. > --- > gnu/packages/mpd.scm | 53 > > 1 file changed, 53 insertions(+) > > diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm > index 27

Re: [PATCH] gnu: Add sonata

2016-09-11 Thread Leo Famulari
On Sun, Sep 11, 2016 at 11:00:37AM +0100, Christopher Baines wrote: > * gnu/packages/mpd.scm (sonata): New variable. Thanks! Pushed as 6c86cef5d36d613be0a62f8f18e276232abf51f0. This will make it easier for my houseguests to control the stereo :)

[PATCH] gnu: Add sonata

2016-09-11 Thread Christopher Baines
Yep, obviously didn't re-read the previous feedback thoroughly enough. gettext is indeed only used at build time. I've attached an updated patch (with just that change).

[PATCH] gnu: Add sonata

2016-09-11 Thread Christopher Baines
* gnu/packages/mpd.scm (sonata): New variable. --- gnu/packages/mpd.scm | 53 1 file changed, 53 insertions(+) diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm index 279ec68..8b1b071 100644 --- a/gnu/packages/mpd.scm +++ b/gnu/packages/

Re: [PATCH] gnu: Add sonata

2016-09-10 Thread Leo Famulari
On Sat, Sep 10, 2016 at 12:31:33PM +0100, Christopher Baines wrote: > * gnu/packages/mpd.scm (sonata): New variable. Wow, I'm very happy to see this package fixed up :) > +(inputs > + `(("gettext" ,gnu-gettext) All looks good to me except for the gettext issue discussed earlier. $ guix

[PATCH] gnu: Add sonata

2016-09-10 Thread Christopher Baines
I've finally got around to updating the patch for sonata, sorry for the long delay.

[PATCH] gnu: Add sonata

2016-09-10 Thread Christopher Baines
* gnu/packages/mpd.scm (sonata): New variable. --- gnu/packages/mpd.scm | 52 1 file changed, 52 insertions(+) diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm index 279ec68..cc9d583 100644 --- a/gnu/packages/mpd.scm +++ b/gnu/packages/